Re: [PATCH v7 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

[Emanuele Giuseppe Esposito]

On 28/06/2021 23:00, Eric Blake wrote:
> On Mon, Jun 28, 2021 at 02:31:48PM +0200, Emanuele Giuseppe Esposito wrote:
> > Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> > Reviewed-by: Max Reitz <mreitz@redhat.com>
> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >   docs/devel/testing.rst | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> > index 8b24e6fb47..fa85592a38 100644
> > --- a/docs/devel/testing.rst
> > +++ b/docs/devel/testing.rst
> > @@ -240,6 +240,13 @@ a failing test:
> >     If the ``-gdb`` option is not used, ``$GDB_OPTIONS`` is ignored,
> >     regardless on whether it is set or not.
> >   
> > +* ``-valgrind`` attaches a valgrind instance to QEMU. If it detects
> > +  warnings, it will print and save the log in
> > +  ``$TEST_DIR/<valgrind_pid>.valgrind``.
> > +  The final command line will be ``valgrind --log-file=$TEST_DIR/
> > +  <valgrind_pid>.valgrind --error-exitcode=99 $QEMU ...``
> > +  Note: if used together with ``-gdb``, this command will be ignored.
>
> Ignored? Or did the previous patch make it an error to try and use
> both at once?

I apologize, I forgot to update the documentation.
You are right in patch 13, the intended behavior is to fail with a 
meaningful error when both flags are used.

Will remove this doc line and update the error message as you suggested.

Thank you,
Emanuele