[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] Some minor optimizations for COLO
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 1/7] Some minor optimizations for COLO |
Date: |
Tue, 29 Jun 2021 18:58:43 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
* Lei Rao (lei.rao@intel.com) wrote:
> From: "Rao, Lei" <lei.rao@intel.com>
>
> Signed-off-by: Lei Rao <lei.rao@intel.com>
> ---
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
OK, although to be honest, I think the compiler will probably do this
for you.
> migration/colo.c | 2 +-
> net/colo-compare.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index 79fa1f6..616dc00 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -152,7 +152,7 @@ static void primary_vm_do_failover(void)
> * kick COLO thread which might wait at
> * qemu_sem_wait(&s->colo_checkpoint_sem).
> */
> - colo_checkpoint_notify(migrate_get_current());
> + colo_checkpoint_notify(s);
>
> /*
> * Wake up COLO thread which may blocked in recv() or send(),
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index b100e7b..4a64a5d 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -170,7 +170,7 @@ static bool packet_matches_str(const char *str,
> return false;
> }
>
> - return !memcmp(str, buf, strlen(str));
> + return !memcmp(str, buf, packet_len);
> }
>
> static void notify_remote_frame(CompareState *s)
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH 0/7] Fixed some bugs and optimized some codes for COLO, Lei Rao, 2021/06/16
- [PATCH 1/7] Some minor optimizations for COLO, Lei Rao, 2021/06/16
- Re: [PATCH 1/7] Some minor optimizations for COLO,
Dr. David Alan Gilbert <=
- [PATCH 2/7] Fixed qemu crash when guest power off in COLO mode, Lei Rao, 2021/06/16
- [PATCH 3/7] Fixed SVM hang when do failover before PVM crash, Lei Rao, 2021/06/16
- [PATCH 4/7] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff, Lei Rao, 2021/06/16
- [PATCH 6/7] Changed the last-mode to none of first start COLO, Lei Rao, 2021/06/16
- [PATCH 5/7] Removed the qemu_fclose() in colo_process_incoming_thread, Lei Rao, 2021/06/16
- [PATCH 7/7] Optimized the function of fill_connection_key., Lei Rao, 2021/06/16