[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 53/63] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*
From: |
Richard Henderson |
Subject: |
[PULL 53/63] tcg: Make use of bswap flags in tcg_gen_qemu_ld_* |
Date: |
Tue, 29 Jun 2021 11:54:45 -0700 |
We can perform any required sign-extension via TCG_BSWAP_OS.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tcg-op.c | 24 ++++++++++--------------
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index 949cbf2f03..0eac2d1969 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op.c
@@ -2876,7 +2876,7 @@ void tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg
idx, MemOp memop)
orig_memop = memop;
if (!TCG_TARGET_HAS_MEMORY_BSWAP && (memop & MO_BSWAP)) {
memop &= ~MO_BSWAP;
- /* The bswap primitive requires zero-extended input. */
+ /* The bswap primitive benefits from zero-extended input. */
if ((memop & MO_SSIZE) == MO_SW) {
memop &= ~MO_SIGN;
}
@@ -2889,10 +2889,9 @@ void tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg
idx, MemOp memop)
if ((orig_memop ^ memop) & MO_BSWAP) {
switch (orig_memop & MO_SIZE) {
case MO_16:
- tcg_gen_bswap16_i32(val, val, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
- if (orig_memop & MO_SIGN) {
- tcg_gen_ext16s_i32(val, val);
- }
+ tcg_gen_bswap16_i32(val, val, (orig_memop & MO_SIGN
+ ? TCG_BSWAP_IZ | TCG_BSWAP_OS
+ : TCG_BSWAP_IZ | TCG_BSWAP_OZ));
break;
case MO_32:
tcg_gen_bswap32_i32(val, val);
@@ -2965,7 +2964,7 @@ void tcg_gen_qemu_ld_i64(TCGv_i64 val, TCGv addr, TCGArg
idx, MemOp memop)
orig_memop = memop;
if (!TCG_TARGET_HAS_MEMORY_BSWAP && (memop & MO_BSWAP)) {
memop &= ~MO_BSWAP;
- /* The bswap primitive requires zero-extended input. */
+ /* The bswap primitive benefits from zero-extended input. */
if ((memop & MO_SIGN) && (memop & MO_SIZE) < MO_64) {
memop &= ~MO_SIGN;
}
@@ -2976,18 +2975,15 @@ void tcg_gen_qemu_ld_i64(TCGv_i64 val, TCGv addr,
TCGArg idx, MemOp memop)
plugin_gen_mem_callbacks(addr, info);
if ((orig_memop ^ memop) & MO_BSWAP) {
+ int flags = (orig_memop & MO_SIGN
+ ? TCG_BSWAP_IZ | TCG_BSWAP_OS
+ : TCG_BSWAP_IZ | TCG_BSWAP_OZ);
switch (orig_memop & MO_SIZE) {
case MO_16:
- tcg_gen_bswap16_i64(val, val, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
- if (orig_memop & MO_SIGN) {
- tcg_gen_ext16s_i64(val, val);
- }
+ tcg_gen_bswap16_i64(val, val, flags);
break;
case MO_32:
- tcg_gen_bswap32_i64(val, val, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
- if (orig_memop & MO_SIGN) {
- tcg_gen_ext32s_i64(val, val);
- }
+ tcg_gen_bswap32_i64(val, val, flags);
break;
case MO_64:
tcg_gen_bswap64_i64(val, val);
--
2.25.1
- [PULL 43/63] tcg/ppc: Split out tcg_out_bswap32, (continued)
- [PULL 43/63] tcg/ppc: Split out tcg_out_bswap32, Richard Henderson, 2021/06/29
- [PULL 44/63] tcg/ppc: Split out tcg_out_bswap64, Richard Henderson, 2021/06/29
- [PULL 48/63] tcg/mips: Support bswap flags in tcg_out_bswap16, Richard Henderson, 2021/06/29
- [PULL 47/63] tcg/s390: Support bswap flags, Richard Henderson, 2021/06/29
- [PULL 49/63] tcg/mips: Support bswap flags in tcg_out_bswap32, Richard Henderson, 2021/06/29
- [PULL 46/63] tcg/ppc: Use power10 byte-reverse instructions, Richard Henderson, 2021/06/29
- [PULL 52/63] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64, Richard Henderson, 2021/06/29
- [PULL 51/63] tcg: Handle new bswap flags during optimize, Richard Henderson, 2021/06/29
- [PULL 54/63] tcg: Make use of bswap flags in tcg_gen_qemu_st_*, Richard Henderson, 2021/06/29
- [PULL 50/63] tcg/tci: Support bswap flags, Richard Henderson, 2021/06/29
- [PULL 53/63] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*,
Richard Henderson <=
- [PULL 57/63] target/arm: Improve REVSH, Richard Henderson, 2021/06/29
- [PULL 59/63] target/sh4: Improve swap.b translation, Richard Henderson, 2021/06/29
- [PULL 56/63] target/arm: Improve vector REV, Richard Henderson, 2021/06/29
- [PULL 58/63] target/i386: Improve bswap translation, Richard Henderson, 2021/06/29
- [PULL 62/63] tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP, Richard Henderson, 2021/06/29
- [PULL 60/63] target/mips: Fix gen_mxu_s32ldd_s32lddr, Richard Henderson, 2021/06/29
- [PULL 55/63] target/arm: Improve REV32, Richard Henderson, 2021/06/29
- [PULL 63/63] tcg/riscv: Remove MO_BSWAP handling, Richard Henderson, 2021/06/29
- [PULL 61/63] tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP, Richard Henderson, 2021/06/29