qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/20] target/loongarch: Add README


From: Song Gao
Subject: Re: [PATCH 01/20] target/loongarch: Add README
Date: Wed, 30 Jun 2021 09:22:05 +0800
User-agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Hi, Peter,

On 06/29/2021 07:52 PM, Peter Maydell wrote:
> On Mon, 28 Jun 2021 at 13:04, Song Gao <gaosong@loongson.cn> wrote:
>>
>> This patch give an introduction to the LoongArch target.
>>
>> Signed-off-by: Song Gao <gaosong@loongson.cn>
>> ---
> 
>> +There are several code directories
>> +
>> +    1 qemu/target/loongarch
>> +        This is the instruction emulation directory
>> +    2 qemu/linux-user/loongarch64
>> +        Linux-user simulation
>> +    3 qemu/hw/loongarch
>> +        System simulation
>> +    4 qemu/tests/tcg/loongarch
>> +        Linux-user test
> 
> This isn't particularly specific to loongarch -- it's how
> all QEMU targets are structured. So I'm not sure you need
> to document it in an loongarch-specific README.
> 
> thanks
> -- PMM
> 

This part is redundant, I'll change it as Alex suggests.

> 
> This part, perhaps slightly expanded is probably better aimed at
> docs/system/target-loongarch.rst so it can be included in the generated
> manual. Bonus points for something along the lines of
> docs/system/arm/versatile.rst where you give a quick breakdown of the
> kernel config and an example command line.
> 

thanks




reply via email to

[Prev in Thread] Current Thread [Next in Thread]