[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/7] ui/vnc: Use qcrypto_tls_creds_check_endpoint()
From: |
Daniel P . Berrangé |
Subject: |
[PULL 6/7] ui/vnc: Use qcrypto_tls_creds_check_endpoint() |
Date: |
Wed, 30 Jun 2021 12:56:11 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Avoid accessing QCryptoTLSCreds internals by using
the qcrypto_tls_creds_check_endpoint() helper.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
ui/vnc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index f0a1550d58..0e5fcb278f 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -46,6 +46,7 @@
#include "qapi/qapi-commands-ui.h"
#include "ui/input.h"
#include "crypto/hash.h"
+#include "crypto/tlscreds.h"
#include "crypto/tlscredsanon.h"
#include "crypto/tlscredsx509.h"
#include "crypto/random.h"
@@ -4080,9 +4081,9 @@ void vnc_display_open(const char *id, Error **errp)
}
object_ref(OBJECT(vd->tlscreds));
- if (vd->tlscreds->endpoint != QCRYPTO_TLS_CREDS_ENDPOINT_SERVER) {
- error_setg(errp,
- "Expecting TLS credentials with a server endpoint");
+ if (!qcrypto_tls_creds_check_endpoint(vd->tlscreds,
+
QCRYPTO_TLS_CREDS_ENDPOINT_SERVER,
+ errp)) {
goto fail;
}
}
--
2.31.1
- [PULL 0/7] crypto patches, Daniel P . Berrangé, 2021/06/30
- [PULL 1/7] crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper, Daniel P . Berrangé, 2021/06/30
- [PULL 2/7] block/nbd: Use qcrypto_tls_creds_check_endpoint(), Daniel P . Berrangé, 2021/06/30
- [PULL 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint(), Daniel P . Berrangé, 2021/06/30
- [PULL 4/7] chardev/socket: Use qcrypto_tls_creds_check_endpoint(), Daniel P . Berrangé, 2021/06/30
- [PULL 5/7] migration/tls: Use qcrypto_tls_creds_check_endpoint(), Daniel P . Berrangé, 2021/06/30
- [PULL 6/7] ui/vnc: Use qcrypto_tls_creds_check_endpoint(),
Daniel P . Berrangé <=
- [PULL 7/7] crypto: Make QCryptoTLSCreds* structures private, Daniel P . Berrangé, 2021/06/30