[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s
From: |
Cornelia Huck |
Subject: |
Re: [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m |
Date: |
Wed, 30 Jun 2021 17:21:44 +0200 |
User-agent: |
Notmuch/0.32.1 (https://notmuchmail.org) |
On Tue, Jun 29 2021, "Cho, Yu-Chen" <acho@suse.com> wrote:
> this will allow to remove the kvm stubs.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> ---
> target/s390x/diag.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/s390x/diag.c b/target/s390x/diag.c
> index c17a2498a7..8405f69df0 100644
> --- a/target/s390x/diag.c
> +++ b/target/s390x/diag.c
> @@ -20,6 +20,7 @@
> #include "hw/s390x/ipl.h"
> #include "hw/s390x/s390-virtio-ccw.h"
> #include "hw/s390x/pv.h"
> +#include "sysemu/kvm.h"
> #include "kvm_s390x.h"
>
> int handle_diag_288(CPUS390XState *env, uint64_t r1, uint64_t r3)
> @@ -168,7 +169,7 @@ out:
> return;
> }
>
> - if (kvm_s390_get_hpage_1m()) {
> + if (kvm_enabled() && kvm_s390_get_hpage_1m()) {
I think I asked before whether we should introduce a
s390_huge_page_backing() wrapper (which might be overkill)... any
opinions on that? I'm not really opposed to this patch here, either.
> error_report("Protected VMs can currently not be backed with "
> "huge pages");
> env->regs[r1 + 1] = DIAG_308_RC_INVAL_FOR_PV;
- [RFC v6 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c, (continued)
- [RFC v6 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c, Cho, Yu-Chen, 2021/06/29
- [RFC v6 03/13] hw/s390x: only build tod-tcg from the CONFIG_TCG build, Cho, Yu-Chen, 2021/06/29
- [RFC v6 04/13] hw/s390x: tod: make explicit checks for accelerators when initializing, Cho, Yu-Chen, 2021/06/29
- [RFC v6 05/13] target/s390x: remove tcg-stub.c, Cho, Yu-Chen, 2021/06/29
- [RFC v6 06/13] target/s390x: start moving TCG-only code to tcg/, Cho, Yu-Chen, 2021/06/29
- [RFC v6 07/13] target/s390x: move sysemu-only code out to cpu-sysemu.c, Cho, Yu-Chen, 2021/06/29
- [RFC v6 08/13] target/s390x: split cpu-dump from helper.c, Cho, Yu-Chen, 2021/06/29
- [RFC v6 09/13] target/s390x: make helper.c sysemu-only, Cho, Yu-Chen, 2021/06/29
- [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m, Cho, Yu-Chen, 2021/06/29
- Re: [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m,
Cornelia Huck <=
- [RFC v6 11/13] target/s390x: remove kvm-stub.c, Cho, Yu-Chen, 2021/06/29
- [RFC v6 12/13] target/s390x: move kvm files into kvm/, Cho, Yu-Chen, 2021/06/29
- [RFC v6 13/13] target/s390x: split sysemu part of cpu models, Cho, Yu-Chen, 2021/06/29
- Re: [RFC v6 00/13] s390x cleanup, Cornelia Huck, 2021/06/30