[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 23/28] target/s390x: Remove use_exit_tb
From: |
Richard Henderson |
Subject: |
[PATCH v2 23/28] target/s390x: Remove use_exit_tb |
Date: |
Wed, 30 Jun 2021 11:32:21 -0700 |
We have not needed to end a TB for I/O since ba3e7926691
("icount: clean up cpu_can_io at the entry to the block").
In use_goto_tb, the check for singlestep_enabled is in the
generic translator_use_goto_tb. In s390x_tr_tb_stop, the
check for singlestep_enabled is in the preceeding do_debug test.
Which leaves only FLAG_MASK_PER: fold that test alone into
the two callers of use_exit tb.
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/translate.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 117a890ecd..4742f59ca9 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -685,16 +685,9 @@ static void gen_op_calc_cc(DisasContext *s)
set_cc_static(s);
}
-static bool use_exit_tb(DisasContext *s)
-{
- return s->base.singlestep_enabled ||
- (tb_cflags(s->base.tb) & CF_LAST_IO) ||
- (s->base.tb->flags & FLAG_MASK_PER);
-}
-
static bool use_goto_tb(DisasContext *s, uint64_t dest)
{
- if (unlikely(use_exit_tb(s))) {
+ if (unlikely(s->base.tb->flags & FLAG_MASK_PER)) {
return false;
}
return translator_use_goto_tb(&s->base, dest);
@@ -6634,7 +6627,7 @@ static void s390x_tr_tb_stop(DisasContextBase *dcbase,
CPUState *cs)
/* Exit the TB, either by raising a debug exception or by return. */
if (dc->do_debug) {
gen_exception(EXCP_DEBUG);
- } else if (use_exit_tb(dc) ||
+ } else if ((dc->base.tb->flags & FLAG_MASK_PER) ||
dc->base.is_jmp == DISAS_PC_STALE_NOCHAIN) {
tcg_gen_exit_tb(NULL, 0);
} else {
--
2.25.1
- [PATCH v2 12/28] target/i386: Use translator_use_goto_tb, (continued)
- [PATCH v2 12/28] target/i386: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 17/28] target/nios2: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 16/28] target/mips: Fix missing else in gen_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 10/28] target/cris: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 11/28] target/hppa: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 13/28] target/m68k: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 14/28] target/microblaze: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 19/28] target/ppc: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 18/28] target/openrisc: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 22/28] target/s390x: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 23/28] target/s390x: Remove use_exit_tb,
Richard Henderson <=
- [PATCH v2 26/28] target/tricore: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 24/28] target/sh4: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 20/28] target/riscv: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 21/28] target/rx: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 07/28] target/arm: Use translator_use_goto_tb for aarch32, Richard Henderson, 2021/06/30
- [PATCH v2 25/28] target/sparc: Use translator_use_goto_tb, Richard Henderson, 2021/06/30
- [PATCH v2 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr, Richard Henderson, 2021/06/30
- [PATCH v2 28/28] target/xtensa: Use translator_use_goto_tb, Richard Henderson, 2021/06/30