[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v6 12/13] target/s390x: move kvm files into kvm/

From: Thomas Huth
Subject: Re: [RFC v6 12/13] target/s390x: move kvm files into kvm/
Date: Thu, 1 Jul 2021 21:30:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 29/06/2021 16.19, Cho, Yu-Chen wrote:
move kvm files into kvm/
After the reshuffling, update MAINTAINERS accordingly.
Make use of the new directory:


Signed-off-by: Claudio Fontana <cfontana@suse.de>
Signed-off-by: Cho, Yu-Chen <acho@suse.com>
diff --git a/meson.build b/meson.build
index a91b39465c..293d509c7e 100644
--- a/meson.build
+++ b/meson.build
@@ -1886,6 +1886,7 @@ if have_system or have_user
+    'target/s390x/kvm',

You've added this to the "have_system or have_user" section ... however, I think the KVM code should not be required at all if compiling with --disable-system, since the linux-user builds require TCG only.

So it might be cleaner to add this in the "if have_system" section instead?

diff --git a/target/s390x/kvm.c b/target/s390x/kvm/kvm.c
similarity index 99%
rename from target/s390x/kvm.c
rename to target/s390x/kvm/kvm.c
index 5b1fdb55c4..07dae06de8 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm/kvm.c
@@ -27,7 +27,7 @@
  #include "qemu-common.h"
  #include "cpu.h"
  #include "s390x-internal.h"
-#include "kvm_s390x.h"
+#include "kvm/kvm_s390x.h"

No need to add the kvm/ prefix here since the file is in the same folder.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]