Re: [PATCH 1/2] Fix for Haiku

[Peter Maydell]

On Sat, 3 Jul 2021 at 22:10, Richard Zak <richard.j.zak@gmail.com> wrote:
>
> For Haiku: turn off TPM, disable mips & xtensa emulators as they won't 
> compile on Haiku, use Haiku's capstone. I'm resending this as I previously 
> sent to the wrong address. This should resolve the memory issue with "make 
> vm-build-haiku.x86_64"


So why don't the mips and xtensa emulators compile on Haiku?
What goes wrong ?

> Signed-off-by: Richard Zak <richard.j.zak@gmail.com>
> ---
>  configure | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index e799d908a3..a965c6c72e 100755
> --- a/configure
> +++ b/configure
> @@ -358,6 +358,7 @@ oss_lib=""
>  bsd="no"
>  linux="no"
>  solaris="no"
> +haiku="no"
>  profiler="no"
>  cocoa="auto"
>  softmmu="yes"
> @@ -769,7 +770,10 @@ SunOS)
>  ;;
>  Haiku)
>    haiku="yes"
> -  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE $QEMU_CFLAGS"
> +  tpm="no"

Why do we need to disable tpm?

> +  capstone="system"
> +  target_list_exclude="mips-softmmu mipsel-softmmu mips64-softmmu 
> mips64el-softmmu xtensa-softmmu xtensaeb-softmmu"
> +  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE -I`finddir 
> B_SYSTEM_HEADERS_DIRECTORY`/capstone $QEMU_CFLAGS"

It seems a bit odd that we have to manually put the capstone headers
on the include path. meson.build runs pkg-config to ask where the system
capstone headers are: does Haiku return the wrong value there?

thanks
-- PMM