[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] colo: Don't dump colo cache if dump-guest-core=off
From: |
Lukas Straub |
Subject: |
[PATCH] colo: Don't dump colo cache if dump-guest-core=off |
Date: |
Sun, 4 Jul 2021 18:14:44 +0200 |
One might set dump-guest-core=off to make coredumps smaller and
still allow to debug many qemu bugs. Extend this option to the colo
cache.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
migration/ram.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 723af67c2e..0797d0d222 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -56,6 +56,8 @@
#include "multifd.h"
#include "sysemu/runstate.h"
+#include "hw/boards.h" /* for machine_dump_guest_core() */
+
#if defined(__linux__)
#include "qemu/userfaultfd.h"
#endif /* defined(__linux__) */
@@ -3356,6 +3358,10 @@ int colo_init_ram_cache(void)
}
return -errno;
}
+ if (!machine_dump_guest_core(current_machine)) {
+ qemu_madvise(block->colo_cache, block->used_length,
+ QEMU_MADV_DONTDUMP);
+ }
}
}
--
2.20.1
pgpnMSqciVnM9.pgp
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] colo: Don't dump colo cache if dump-guest-core=off,
Lukas Straub <=