[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/22] tests/docker: remove FEATURES env var from template
From: |
Alex Bennée |
Subject: |
Re: [PATCH v4 05/22] tests/docker: remove FEATURES env var from templates |
Date: |
Mon, 05 Jul 2021 13:36:48 +0100 |
User-agent: |
mu4e 1.5.13; emacs 28.0.50 |
Daniel P. Berrangé <berrange@redhat.com> writes:
> In preparation for switching to auto-generated dockerfiles, remove the
> FEATURES env variable. The equivalent functionality can be achieved in
> most cases by just looking for existance of a binary.
>
> The cases which don't correspond to binaries are simply dropped because
> configure/meson will probe for any requested feature anyway.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée