qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 18/18] vhost-vdpa: multiqueue support


From: Jason Wang
Subject: Re: [PATCH 18/18] vhost-vdpa: multiqueue support
Date: Tue, 6 Jul 2021 15:46:29 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0


在 2021/7/1 下午2:51, Eugenio Perez Martin 写道:
       * provide control queue via peers as well.
       */
      if (n->nic_conf.peers.queues) {
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index cc11b2ec40..048344b4bc 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -18,6 +18,7 @@
  #include "qemu/error-report.h"
  #include "qemu/option.h"
  #include "qapi/error.h"
+#include <linux/vhost.h>
  #include <sys/ioctl.h>
  #include <err.h>
  #include "standard-headers/linux/virtio_net.h"
@@ -52,6 +53,8 @@ const int vdpa_feature_bits[] = {
      VIRTIO_NET_F_HOST_UFO,
      VIRTIO_NET_F_MRG_RXBUF,
      VIRTIO_NET_F_MTU,
+    VIRTIO_NET_F_MQ,
+    VIRTIO_NET_F_CTRL_VQ,
Hi!

I'm not sure if it's qemu the one that must control it, but I cannot
use vdpa_sim of linux 5.13 (i.e., with no control vq patches) with
this series applied:

[    3.967421] virtio_net virtio0: device advertises feature
VIRTIO_NET_F_CTRL_RX but not VIRTIO_NET_F_CTRL_VQ
[    3.968613] virtio_net: probe of virtio0 failed with error -22

Did you mention it somewhere else and I've missed it? or is it
actually a bug in the device? In this second case, I think we should
still workaround it in qemu, because old vdpasim_net with no
VIRTIO_NET_F_CTRL_VQ still works ok without this patch.

Thanks!


So the problem is we need not only validating MQ but also all the features that depends on the CTRL VQ here (rx filters, mac, rss, announce etc).

I will fix this in the next version.

Thanks





reply via email to

[Prev in Thread] Current Thread [Next in Thread]