[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support |
Date: |
Tue, 6 Jul 2021 15:19:36 +0200 |
Am 02.07.2021 um 19:23 hat Ilya Dryomov geschrieben:
> This series migrates the qemu rbd driver from the old aio emulation
> to native coroutines and adds write zeroes support which is important
> for block operations.
>
> To achieve this we first bump the librbd requirement to the already
> outdated luminous release of ceph to get rid of some wrappers and
> ifdef'ry in the code.
Thanks, applied to the block branch.
I've only had a very quick look at the patches, but I think there is one
suggestion for a cleanup I can make: The qemu_rbd_finish_bh()
indirection is probably unnecessary now because aio_co_wake() is thread
safe.
(Also, if I were the responsible maintainer, I would prefer true/false
rather than 0/1 for bools, but that's minor. :-))
Kevin
- [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Ilya Dryomov, 2021/07/02
- [PATCH v5 2/6] block/rbd: store object_size in BDRVRBDState, Ilya Dryomov, 2021/07/02
- [PATCH v5 3/6] block/rbd: update s->image_size in qemu_rbd_getlength, Ilya Dryomov, 2021/07/02
- [PATCH v5 1/6] block/rbd: bump librbd requirement to luminous release, Ilya Dryomov, 2021/07/02
- [PATCH v5 4/6] block/rbd: migrate from aio to coroutines, Ilya Dryomov, 2021/07/02
- [PATCH v5 6/6] block/rbd: drop qemu_rbd_refresh_limits, Ilya Dryomov, 2021/07/02
- [PATCH v5 5/6] block/rbd: add write zeroes support, Ilya Dryomov, 2021/07/02
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Ilya Dryomov, 2021/07/02
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support,
Kevin Wolf <=
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Peter Lieven, 2021/07/06
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Kevin Wolf, 2021/07/06
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Peter Lieven, 2021/07/06
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Peter Lieven, 2021/07/07
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Kevin Wolf, 2021/07/08
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Peter Lieven, 2021/07/08
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Kevin Wolf, 2021/07/09