[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 26/36] linux-user/mips: Tidy install_sigtramp
From: |
Richard Henderson |
Subject: |
[PATCH v2 26/36] linux-user/mips: Tidy install_sigtramp |
Date: |
Tue, 6 Jul 2021 16:49:22 -0700 |
The return value is constant 0, and unused as well -- change to void.
Drop inline marker. Change tramp type to uint32_t* for clarity.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/mips/signal.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/linux-user/mips/signal.c b/linux-user/mips/signal.c
index e6be807a81..7cad7526ea 100644
--- a/linux-user/mips/signal.c
+++ b/linux-user/mips/signal.c
@@ -86,10 +86,8 @@ struct target_rt_sigframe {
};
/* Install trampoline to jump back from signal handler */
-static inline int install_sigtramp(unsigned int *tramp, unsigned int syscall)
+static void install_sigtramp(uint32_t *tramp, unsigned int syscall)
{
- int err = 0;
-
/*
* Set up the return code ...
*
@@ -99,7 +97,6 @@ static inline int install_sigtramp(unsigned int *tramp,
unsigned int syscall)
__put_user(0x24020000 + syscall, tramp + 0);
__put_user(0x0000000c , tramp + 1);
- return err;
}
static inline void setup_sigcontext(CPUMIPSState *regs,
--
2.25.1
- RE: [PATCH v2 19/36] linux-user/hexagon: Implement setup_sigtramp, (continued)
- [PATCH v2 20/36] linux-user/hppa: Add vdso and use it for rt_sigreturn, Richard Henderson, 2021/07/06
- [PATCH v2 21/36] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set, Richard Henderson, 2021/07/06
- [PATCH v2 23/36] linux-user/x86_64: Add vdso, Richard Henderson, 2021/07/06
- [PATCH v2 22/36] linux-user/i386: Add vdso and use it for sigreturn, Richard Henderson, 2021/07/06
- [PATCH v2 28/36] linux-user/nios2: Document non-use of setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 25/36] linux-user/microblaze: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 29/36] linux-user/openrisc: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 27/36] linux-user/mips: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 26/36] linux-user/mips: Tidy install_sigtramp,
Richard Henderson <=
- [PATCH v2 24/36] linux-user/m68k: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 30/36] target/ppc: Simplify encode_trampoline, Richard Henderson, 2021/07/06
- [PATCH v2 31/36] linux-user/ppc: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 33/36] linux-user/s390x: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 32/36] linux-user/riscv: Add vdso and use it for sigreturn, Richard Henderson, 2021/07/06
- [PATCH v2 34/36] linux-user/sh4: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 35/36] linux-user/sparc: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 36/36] linux-user/xtensa: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- Re: [PATCH v2 00/36] linux-user: Signal trampolines and vdsos, Philippe Mathieu-Daudé, 2021/07/08