qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/12] linux-user: Extract target errno to 'target_errno_defs


From: Richard Henderson
Subject: Re: [PATCH 05/12] linux-user: Extract target errno to 'target_errno_defs.h'
Date: Tue, 6 Jul 2021 18:53:51 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote:
We want to access the target errno indepently of the rest
of the linux-user code. Extract it to a new target-specific
header: 'target_errno_defs.h'.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
  linux-user/aarch64/target_errno_defs.h    | 6 ++++++
  linux-user/alpha/target_errno_defs.h      | 4 ++++
  linux-user/arm/target_errno_defs.h        | 6 ++++++
  linux-user/cris/target_errno_defs.h       | 6 ++++++
  linux-user/errno_defs.h                   | 3 +++
  linux-user/hexagon/target_errno_defs.h    | 6 ++++++
  linux-user/hppa/target_errno_defs.h       | 4 ++++
  linux-user/i386/target_errno_defs.h       | 6 ++++++
  linux-user/m68k/target_errno_defs.h       | 6 ++++++
  linux-user/microblaze/target_errno_defs.h | 6 ++++++
  linux-user/mips/target_errno_defs.h       | 4 ++++
  linux-user/mips64/target_errno_defs.h     | 4 ++++
  linux-user/nios2/target_errno_defs.h      | 6 ++++++
  linux-user/openrisc/target_errno_defs.h   | 6 ++++++
  linux-user/ppc/target_errno_defs.h        | 6 ++++++
  linux-user/riscv/target_errno_defs.h      | 6 ++++++
  linux-user/s390x/target_errno_defs.h      | 6 ++++++
  linux-user/sh4/target_errno_defs.h        | 6 ++++++
  linux-user/sparc/target_syscall.h         | 2 --
  linux-user/x86_64/target_errno_defs.h     | 6 ++++++
  linux-user/xtensa/target_errno_defs.h     | 6 ++++++
  21 files changed, 109 insertions(+), 2 deletions(-)
  create mode 100644 linux-user/aarch64/target_errno_defs.h
  create mode 100644 linux-user/alpha/target_errno_defs.h
  create mode 100644 linux-user/arm/target_errno_defs.h
  create mode 100644 linux-user/cris/target_errno_defs.h
  create mode 100644 linux-user/hexagon/target_errno_defs.h
  create mode 100644 linux-user/hppa/target_errno_defs.h
  create mode 100644 linux-user/i386/target_errno_defs.h
  create mode 100644 linux-user/m68k/target_errno_defs.h
  create mode 100644 linux-user/microblaze/target_errno_defs.h
  create mode 100644 linux-user/mips/target_errno_defs.h
  create mode 100644 linux-user/mips64/target_errno_defs.h
  create mode 100644 linux-user/nios2/target_errno_defs.h
  create mode 100644 linux-user/openrisc/target_errno_defs.h
  create mode 100644 linux-user/ppc/target_errno_defs.h
  create mode 100644 linux-user/riscv/target_errno_defs.h
  create mode 100644 linux-user/s390x/target_errno_defs.h
  create mode 100644 linux-user/sh4/target_errno_defs.h
  create mode 100644 linux-user/x86_64/target_errno_defs.h
  create mode 100644 linux-user/xtensa/target_errno_defs.h

diff --git a/linux-user/aarch64/target_errno_defs.h 
b/linux-user/aarch64/target_errno_defs.h
new file mode 100644
index 00000000000..a809381165a
--- /dev/null
+++ b/linux-user/aarch64/target_errno_defs.h
@@ -0,0 +1,6 @@
+#ifndef AARCH64_TARGET_ERRNO_H
+#define AARCH64_TARGET_ERRNO_H
+
+/* Target uses generic errno */
+
+#endif

This could be better.

Consider e.g. termbits.h as the model.
These targets should have exactly one line:

#include "../generic/target_errno.h"

diff --git a/linux-user/alpha/target_errno_defs.h 
b/linux-user/alpha/target_errno_defs.h
new file mode 100644
index 00000000000..13770b14b82
--- /dev/null
+++ b/linux-user/alpha/target_errno_defs.h
@@ -0,0 +1,4 @@
+#ifndef ALPHA_TARGET_ERRNO_H
+#define ALPHA_TARGET_ERRNO_H
+
+#endif

This one, and ones like it, become

#ifndef ALPHA_TARGET_ERRNO_H
#define ALPHA_TARGET_ERRNO_H

#include "../generic/target_errno.h"

#undef  TARGET_EBAR
#define TARGET_EBAR  xxx
...

#endif


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]