Re: [PATCH 1/4] hw/nvme: remove NvmeCtrl parameter from ns setup/check functions

[Hannes Reinecke]

On 7/6/21 11:33 AM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The nvme_ns_setup and nvme_ns_check_constraints should not depend on the
> controller state. Refactor and remove it.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/nvme/nvme.h |  2 +-
>   hw/nvme/ctrl.c |  2 +-
>   hw/nvme/ns.c   | 37 ++++++++++++++++++-------------------
>   3 files changed, 20 insertions(+), 21 deletions(-)
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer