[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/5] configure: allow the selection of alternate config in

From: Richard Henderson
Subject: Re: [PATCH v2 5/5] configure: allow the selection of alternate config in the build
Date: Wed, 7 Jul 2021 08:16:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/7/21 6:17 AM, Alex Bennée wrote:
While the default config works well enough it does end up enabling a
lot of stuff. For more minimal builds we can select a different list
of devices and let Kconfig work out what we want. For example:

   ../../configure --without-default-features \
     --target-list=arm-softmmu,aarch64-softmmu \

will override the aarch64-softmmu default set of devices with a more
minimal set of devices that just enables the virt and sbsa-ref models.

Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
Cc: Philippe Mathieu-Daudé<philmd@redhat.com>
Cc: Paolo Bonzini<pbonzini@redhat.com>

I guess I can just follow the shell scripting. It's a shame we can't just put together the properties section contents while we're parsing the command-line, and instead have to break it up into N variables.

+  # unroll any custom device configs
+  if test -n "$device_archs"; then
+      for a in $device_archs; do
+          eval "c=\$devices_${a}"
+          echo "${a}-softmmu = '$c'" >> $cross
+      done
+  fi

Do you really need the IF around the FOR? Shouldn't the loop iterate zero times if $device_archs is empty?

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]