Re: [PATCH v2 10/28] target/cris: Use translator_use_goto_tb

[Peter Maydell]

On Wed, 30 Jun 2021 at 19:43, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The test for singlestepping is done in translator_use_goto_tb,
> so we may elide it from cris_tr_tb_stop.
>
> Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/cris/translate.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index 4cfe5c86d9..e33a3bb326 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -482,7 +482,7 @@ static void t_gen_swapr(TCGv d, TCGv s)
>
>  static bool use_goto_tb(DisasContext *dc, target_ulong dest)
>  {
> -    return ((dest ^ dc->base.pc_first) & TARGET_PAGE_MASK) == 0;
> +    return translator_use_goto_tb(&dc->base, dest);
>  }

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM