[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/28] target/alpha: Remove use_exit_tb

From: Peter Maydell
Subject: Re: [PATCH v2 02/28] target/alpha: Remove use_exit_tb
Date: Thu, 8 Jul 2021 13:34:18 +0100

On Wed, 30 Jun 2021 at 19:39, Richard Henderson
<richard.henderson@linaro.org> wrote:
> We have not needed to end a TB for I/O since ba3e7926691
> ("icount: clean up cpu_can_io at the entry to the block").
> We do not need to use exit_tb for singlestep, which only
> means generate one insn per TB.
> Which leaves only singlestep_enabled, which means raise a
> debug trap after every TB, which does not use exit_tb,
> which would leave the function mis-named.
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

I wonder if we should rename the 'singlestep' global to
'tcg_one_insn_per_tb' or something (and perhaps also provide a
new command line flag, with the old one deprecated). It's very
misleadingly named...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]