[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] Acceptance Tests: move definition of distro checksums to

From: Cleber Rosa
Subject: Re: [PATCH 2/3] Acceptance Tests: move definition of distro checksums to the framework
Date: Thu, 8 Jul 2021 10:47:03 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 4/22/21 3:56 AM, Auger Eric wrote:
Hi Cleber,

On 4/15/21 12:14 AM, Cleber Rosa wrote:
Instead of having, by default, the checksum in the tests, and the
definition of tests in the framework, let's keep them together.

A central definition for distributions is available, and it should
allow other known distros to be added more easily.

No behavior change is expected here, and tests can still define
a distro_checksum value if for some reason they want to override
the known distribution information.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
  tests/acceptance/avocado_qemu/__init__.py | 34 +++++++++++++++++++++--
  tests/acceptance/boot_linux.py            |  8 ------
  2 files changed, 32 insertions(+), 10 deletions(-)

diff --git a/tests/acceptance/avocado_qemu/__init__.py 
index aae1e5bbc9..97093614d9 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -299,6 +299,30 @@ def ssh_command(self, command):
          return stdout_lines, stderr_lines
+#: A collection of known distros and their respective image checksum
+    'fedora': {
+        '31': {
+            'x86_64':
+            {'checksum': 
+            'aarch64':
+            {'checksum': 
+            'ppc64':
+            {'checksum': 
+            's390x':
+            {'checksum': 
+            }
+        }
+    }
assuming we may put other data like kernel params and maybe pxeboot URL,
this may grow rapidly, Maybe we should put that in a different file?

Hi Eric,

Sorry for the monstrous delay here.  You and I are thinking alike, but I'm planning to handle this on the Avocado side.  I'm writing a BluePrint[1] for what would be a revision of the Avocado asset API.  In that new proposal, data files (some builtin, some external) would be used to contain information about known assets.

So, for now, I think it's better to keep this AS IS.  Let me know if this works for you.


- Cleber.

[1] - https://github.com/avocado-framework/avocado/issues/4458

reply via email to

[Prev in Thread] Current Thread [Next in Thread]