[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] audio: Make the AudiodevDriver enum conditional

From: Markus Armbruster
Subject: Re: [RFC PATCH] audio: Make the AudiodevDriver enum conditional
Date: Thu, 08 Jul 2021 16:56:29 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Thomas Huth <thuth@redhat.com> writes:

> On 25/06/2021 10.30, Daniel P. Berrangé wrote:
>> On Thu, Jun 24, 2021 at 08:37:16PM +0200, Thomas Huth wrote:
>>> This way, the upper layers like libvirt could have the possibility
>>> to use QAPI to find out which audio drivers have been enabled during
>>> compile-time of QEMU.
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   Note: Marked as RFC since it's quite a lot of ifdef'ing here...
>>>         not sure whether I really like it...
>> Same as my patch here:
>>    https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg00654.html
> Oh, nice, I guess it means that it's not such a bad idea to introduce
> all those #ifdefs here :-)
> Anyway, looks like my patch was incomplete anyway (I just hacked it
> together after my corresponding DisplayType patch - see 
> https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06529.html),
> since it lacks the wiring via a qapi command, so please disregard this
> RFC PATCH. Are you going to respin your series from March, Daniel?

I reviewed Daniel's series back then, and pointed out a few minor
issues, mostly in commit messages.  I hope that wasn't the reason for it
getting stuck :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]