Re: [PATCH 3/7] tests: Add suffix tpm2 or tpm12 to ACPI table files

[Igor Mammedov]

On Thu, 8 Jul 2021 10:17:51 -0400
Stefan Berger <stefanb@linux.ibm.com> wrote:

> On 7/8/21 9:59 AM, Igor Mammedov wrote:
> > On Wed, 30 Jun 2021 11:37:19 -0400
> > Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
> >  
> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> >> ---
> >>   tests/data/acpi/q35/{DSDT.tis => DSDT.tis.tpm2} | Bin
> >>   tests/data/acpi/q35/{TPM2.tis => TPM2.tis.tpm2} | Bin
> >>   tests/qtest/bios-tables-test.c                  |   3 ++-
> >>   3 files changed, 2 insertions(+), 1 deletion(-)
> >>   rename tests/data/acpi/q35/{DSDT.tis => DSDT.tis.tpm2} (100%)
> >>   rename tests/data/acpi/q35/{TPM2.tis => TPM2.tis.tpm2} (100%)  
> > it fails checkpatch which falsely detects it as adding new files
> >
> > ERROR: Do not add expected files together with tests, follow instructions 
> > in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis.tpm2 
> > and tests/qtest/bios-tables-test.c found
> >
> > ERROR: Do not add expected files together with tests, follow instructions 
> > in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis.tpm2 
> > and tests/qtest/bios-tables-test.c found
> >
> > looks like checkpatch needs to be fixed to handle testcase variant 
> > renaming.  
> 
> Is this a show stopper for upstreaming it?
patch itself looks fine to me but I'm not sure if it's possible CCing 
Michael/Peter.