[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 07/35] acpi: acpi_build_hest: use acpi_init_table()/acpi_table
From: |
Igor Mammedov |
Subject: |
[PATCH v2 07/35] acpi: acpi_build_hest: use acpi_init_table()/acpi_table_composed() instead of build_header() |
Date: |
Thu, 8 Jul 2021 11:45:49 -0400 |
it replaces error-prone pointer arithmetic for build_header() API,
with 2 calls to start and finish table creation,
which hides offsets magic from API user.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Dongjiu Geng <gengdongjiu1@gmail.com>
---
CC: qemu-arm@nongnu.org
CC: drjones@redhat.com
CC: gengdongjiu1@gmail.com
---
hw/acpi/ghes.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index a749b84d62..bf58600a80 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -362,18 +362,16 @@ static void build_ghes_v2(GArray *table_data, int
source_id, BIOSLinker *linker)
void acpi_build_hest(GArray *table_data, BIOSLinker *linker,
const char *oem_id, const char *oem_table_id)
{
- uint64_t hest_start = table_data->len;
+ AcpiTable table = { .sig = "HEST", .rev = 1,
+ .oem_id = oem_id, .oem_table_id = oem_table_id };
- /* Hardware Error Source Table header*/
- acpi_data_push(table_data, sizeof(AcpiTableHeader));
+ acpi_init_table(&table, table_data);
/* Error Source Count */
build_append_int_noprefix(table_data, ACPI_GHES_ERROR_SOURCE_COUNT, 4);
-
build_ghes_v2(table_data, ACPI_HEST_SRC_ID_SEA, linker);
- build_header(linker, table_data, (void *)(table_data->data + hest_start),
- "HEST", table_data->len - hest_start, 1, oem_id,
oem_table_id);
+ acpi_table_composed(linker, &table);
}
void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s,
--
2.27.0
- [PATCH v2 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables, Igor Mammedov, 2021/07/08
- [PATCH v2 01/35] acpi: add helper routines to initialize ACPI tables, Igor Mammedov, 2021/07/08
- [PATCH v2 02/35] acpi: build_rsdt: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 04/35] acpi: build_slit: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 03/35] acpi: build_xsdt: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 06/35] acpi: build_tpm2: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 05/35] acpi: build_fadt: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 08/35] acpi: build_mcfg: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 09/35] acpi: build_hmat: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 10/35] acpi: nvdimm_build_nfit: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 07/35] acpi: acpi_build_hest: use acpi_init_table()/acpi_table_composed() instead of build_header(),
Igor Mammedov <=
- [PATCH v2 11/35] acpi: nvdimm_build_ssdt: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 12/35] acpi: vmgenid_build_acpi: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 14/35] acpi: build_hpet: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 13/35] acpi: x86: build_dsdt: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 16/35] acpi: arm/x86: build_srat: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 15/35] acpi: build_tpm_tcpa: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 18/35] acpi: build_dmar_q35: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 17/35] acpi: use build_append_int_noprefix() API to compose SRAT table, Igor Mammedov, 2021/07/08
- [PATCH v2 19/35] acpi: build_waet: use acpi_init_table()/acpi_table_composed() instead of build_header(), Igor Mammedov, 2021/07/08
- [PATCH v2 22/35] acpi: x86: remove dead code, Igor Mammedov, 2021/07/08