[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 20/28] target/riscv: Use translator_use_goto_tb
From: |
Richard Henderson |
Subject: |
[PATCH v3 20/28] target/riscv: Use translator_use_goto_tb |
Date: |
Thu, 8 Jul 2021 09:40:42 -0700 |
Just use translator_use_goto_tb directly at the one call site,
rather than maintaining a local wrapper.
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/riscv/translate.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index 62a7d7e4c7..deda0c8a44 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -168,29 +168,11 @@ static void gen_exception_inst_addr_mis(DisasContext *ctx)
generate_exception_mtval(ctx, RISCV_EXCP_INST_ADDR_MIS);
}
-static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest)
-{
- if (unlikely(ctx->base.singlestep_enabled)) {
- return false;
- }
-
-#ifndef CONFIG_USER_ONLY
- return (ctx->base.tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK);
-#else
- return true;
-#endif
-}
-
static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest)
{
- if (use_goto_tb(ctx, dest)) {
- /* chaining is only allowed when the jump is to the same page */
+ if (translator_use_goto_tb(&ctx->base, dest)) {
tcg_gen_goto_tb(n);
tcg_gen_movi_tl(cpu_pc, dest);
-
- /* No need to check for single stepping here as use_goto_tb() will
- * return false in case of single stepping.
- */
tcg_gen_exit_tb(ctx->base.tb, n);
} else {
tcg_gen_movi_tl(cpu_pc, dest);
--
2.25.1
- [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32, (continued)
- [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32, Richard Henderson, 2021/07/08
- [PATCH v3 03/28] target/alpha: Remove in_superpage, Richard Henderson, 2021/07/08
- [PATCH v3 12/28] target/i386: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 10/28] target/cris: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 09/28] target/avr: Mark some helpers noreturn, Richard Henderson, 2021/07/08
- [PATCH v3 08/28] target/avr: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 15/28] target/mips: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 25/28] target/sparc: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 11/28] target/hppa: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 17/28] target/nios2: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 20/28] target/riscv: Use translator_use_goto_tb,
Richard Henderson <=
- [PATCH v3 14/28] target/microblaze: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 19/28] target/ppc: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr, Richard Henderson, 2021/07/08
- [PATCH v3 24/28] target/sh4: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 16/28] target/mips: Fix missing else in gen_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 18/28] target/openrisc: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 23/28] target/s390x: Remove use_exit_tb, Richard Henderson, 2021/07/08
- [PATCH v3 22/28] target/s390x: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 21/28] target/rx: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 28/28] target/xtensa: Use translator_use_goto_tb, Richard Henderson, 2021/07/08