[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 01/14] target/s390x: meson: add target_user_arch

From: Cornelia Huck
Subject: Re: [PATCH v7 01/14] target/s390x: meson: add target_user_arch
Date: Thu, 08 Jul 2021 19:20:09 +0200
User-agent: Notmuch/0.32.1 (https://notmuchmail.org)

On Wed, Jul 07 2021, "Cho, Yu-Chen" <acho@suse.com> wrote:

> the lack of target_user_arch makes it hard to fully leverage the
> build system in order to separate user code from sysemu code.
> Provide it, so that we can avoid the proliferation of #ifdef
> in target code.
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>

Just noticed when I was sending a pull request: your unquoted name in
the s-o-b confuses git send-email when it is doing its automatic cc:s
(it adds a 'cc:Cho', which is obviously bogus and leads to the mail
being rejected by the list server.) Not sure whether git send-email
should add proper quoting itself, but putting quoting in the s-o-b line
is probably a good idea (I'm wondering why git didn't add it in the
first place.)

Are you fine with me modifying your s-o-b lines in the commits to
include quoting, if I need to resend the pull req?

> Acked-by: Cornelia Huck <cohuck@redhat.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/s390x/meson.build | 3 +++
>  1 file changed, 3 insertions(+)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]