[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 32/39] contrib/plugins: enable -Wall for building plugins
From: |
Alex Bennée |
Subject: |
[PATCH v2 32/39] contrib/plugins: enable -Wall for building plugins |
Date: |
Thu, 8 Jul 2021 20:09:34 +0100 |
Lets spot the obvious errors.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v2
- also $(filter -W%, $(QEMU_CFLAGS)) from the main build
---
contrib/plugins/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile
index b9d7935e5e..3431bc1ce9 100644
--- a/contrib/plugins/Makefile
+++ b/contrib/plugins/Makefile
@@ -24,7 +24,7 @@ SONAMES := $(addsuffix .so,$(addprefix lib,$(NAMES)))
# The main QEMU uses Glib extensively so it's perfectly fine to use it
# in plugins (which many example do).
CFLAGS = $(GLIB_CFLAGS)
-CFLAGS += -fPIC
+CFLAGS += -fPIC -Wall $(filter -W%, $(QEMU_CFLAGS))
CFLAGS += $(if $(findstring no-psabi,$(QEMU_CFLAGS)),-Wpsabi)
CFLAGS += -I$(SRC_PATH)/include/qemu
--
2.20.1
- [PATCH v2 10/39] tests/docker: don't use BUILDKIT in GitLab either, (continued)
- [PATCH v2 10/39] tests/docker: don't use BUILDKIT in GitLab either, Alex Bennée, 2021/07/08
- [PATCH v2 13/39] tests/docker: remove FEATURES env var from templates, Alex Bennée, 2021/07/08
- [PATCH v2 11/39] tests/docker: use project specific container registries, Alex Bennée, 2021/07/08
- [PATCH v2 21/39] tests/docker: expand ubuntu1804 package list, Alex Bennée, 2021/07/08
- [PATCH v2 31/39] tcg/plugins: enable by default for TCG builds, Alex Bennée, 2021/07/08
- [PATCH v2 34/39] docs/devel: tcg-plugins: add execlog plugin description, Alex Bennée, 2021/07/08
- [PATCH v2 30/39] configure: stop user enabling plugins on Windows for now, Alex Bennée, 2021/07/08
- [PATCH v2 39/39] MAINTAINERS: Added myself as a reviewer for TCG Plugins, Alex Bennée, 2021/07/08
- [PATCH v2 32/39] contrib/plugins: enable -Wall for building plugins,
Alex Bennée <=
- [PATCH v2 18/39] tests/docker: remove mingw packages from Fedora, Alex Bennée, 2021/07/08
- [PATCH v2 16/39] tests/docker: fix mistakes in fedora package list, Alex Bennée, 2021/07/08
- [PATCH v2 28/39] meson.build: move TCG plugin summary output, Alex Bennée, 2021/07/08
- [PATCH v2 24/39] tests/vm: update NetBSD to 9.2, Alex Bennée, 2021/07/08
- [PATCH v2 38/39] docs/devel: Added cache plugin to the plugins docs, Alex Bennée, 2021/07/08
- [PATCH v2 26/39] tests/tcg: make test-mmap a little less aggressive, Alex Bennée, 2021/07/08