[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 14/15] virtio-mem: Require only coordinated discards
From: |
Eduardo Habkost |
Subject: |
[PULL v2 14/15] virtio-mem: Require only coordinated discards |
Date: |
Thu, 8 Jul 2021 15:55:51 -0400 |
From: David Hildenbrand <david@redhat.com>
We implement the RamDiscardManager interface and only require coordinated
discarding of RAM to work.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Auger Eric <eric.auger@redhat.com>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: teawater <teawaterz@linux.alibaba.com>
Cc: Marek Kedzierski <mkedzier@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210413095531.25603-13-david@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/virtio/virtio-mem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index 368ae1db903..df91e454b2f 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -719,7 +719,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
Error **errp)
return;
}
- if (ram_block_discard_require(true)) {
+ if (ram_block_coordinated_discard_require(true)) {
error_setg(errp, "Discarding RAM is disabled");
return;
}
@@ -727,7 +727,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
Error **errp)
ret = ram_block_discard_range(rb, 0, qemu_ram_get_used_length(rb));
if (ret) {
error_setg_errno(errp, -ret, "Unexpected error discarding RAM");
- ram_block_discard_require(false);
+ ram_block_coordinated_discard_require(false);
return;
}
@@ -771,7 +771,7 @@ static void virtio_mem_device_unrealize(DeviceState *dev)
virtio_del_queue(vdev, 0);
virtio_cleanup(vdev);
g_free(vmem->bitmap);
- ram_block_discard_require(false);
+ ram_block_coordinated_discard_require(false);
}
static int virtio_mem_discard_range_cb(const VirtIOMEM *vmem, void *arg,
--
2.31.1
- [PULL v2 03/15] memory: Introduce RamDiscardManager for RAM memory regions, (continued)
- [PULL v2 03/15] memory: Introduce RamDiscardManager for RAM memory regions, Eduardo Habkost, 2021/07/08
- [PULL v2 04/15] memory: Helpers to copy/free a MemoryRegionSection, Eduardo Habkost, 2021/07/08
- [PULL v2 05/15] virtio-mem: Factor out traversing unplugged ranges, Eduardo Habkost, 2021/07/08
- [PULL v2 06/15] virtio-mem: Don't report errors when ram_block_discard_range() fails, Eduardo Habkost, 2021/07/08
- [PULL v2 07/15] virtio-mem: Implement RamDiscardManager interface, Eduardo Habkost, 2021/07/08
- [PULL v2 08/15] vfio: Support for RamDiscardManager in the !vIOMMU case, Eduardo Habkost, 2021/07/08
- [PULL v2 09/15] vfio: Query and store the maximum number of possible DMA mappings, Eduardo Habkost, 2021/07/08
- [PULL v2 10/15] vfio: Sanity check maximum number of DMA mappings with RamDiscardManager, Eduardo Habkost, 2021/07/08
- [PULL v2 11/15] vfio: Support for RamDiscardManager in the vIOMMU case, Eduardo Habkost, 2021/07/08
- [PULL v2 12/15] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require), Eduardo Habkost, 2021/07/08
- [PULL v2 14/15] virtio-mem: Require only coordinated discards,
Eduardo Habkost <=
- [PULL v2 13/15] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types, Eduardo Habkost, 2021/07/08
- [PULL v2 15/15] vfio: Disable only uncoordinated discards for VFIO_TYPE1 iommus, Eduardo Habkost, 2021/07/08
- Re: [PULL v2 00/15] Machine queue, 2021-07-07, Peter Maydell, 2021/07/10