Re: [PATCH] Move qemu.sasl to contrib/

[Daniel P . Berrangé]

On Thu, Jul 08, 2021 at 04:49:24PM -0400, Cole Robinson wrote:
> On 7/8/21 3:18 PM, Peter Maydell wrote:
> > On Thu, 8 Jul 2021 at 20:14, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >>
> >> On Thu, Jul 08, 2021 at 02:39:57PM -0400, Cole Robinson wrote:
> >>> It's not installed in any way, so seems like contrib/ material
> >>
> >> Not really.
> >>
> >> Contrib is stuff that is included on an ad-hoc basis with no
> >> commitment to support and no guarantee that it is working at
> >> all.  Yes, there is some stuff in contrib/ that doesn't
> >> belong there based on this definition, and should be moved
> >> out.
> > 
> > More generally, I would like to see us get rid of contrib/
> > entirely. We should either support stuff (and have it in
> > sensible places in the source tree) or kick it out.
> > 
> 
> qemu.sasl to ui/ dir then?

Yeah, probably best

> Do you think we should install qemu.sasl to /etc/sasl2/qemu.conf? Its
> what Fedora/RHEL packaging does by hand for qemu. And what libvirt does
> for its equivalent config file

Yes.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|