[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 33/40] contrib/plugins: enable -Wall for building plugins
From: |
Alex Bennée |
Subject: |
[PATCH v3 33/40] contrib/plugins: enable -Wall for building plugins |
Date: |
Fri, 9 Jul 2021 15:29:58 +0100 |
Lets spot the obvious errors.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v2
- also $(filter -W%, $(QEMU_CFLAGS)) from the main build
---
contrib/plugins/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile
index b9d7935e5e..3431bc1ce9 100644
--- a/contrib/plugins/Makefile
+++ b/contrib/plugins/Makefile
@@ -24,7 +24,7 @@ SONAMES := $(addsuffix .so,$(addprefix lib,$(NAMES)))
# The main QEMU uses Glib extensively so it's perfectly fine to use it
# in plugins (which many example do).
CFLAGS = $(GLIB_CFLAGS)
-CFLAGS += -fPIC
+CFLAGS += -fPIC -Wall $(filter -W%, $(QEMU_CFLAGS))
CFLAGS += $(if $(findstring no-psabi,$(QEMU_CFLAGS)),-Wpsabi)
CFLAGS += -I$(SRC_PATH)/include/qemu
--
2.20.1
- [PATCH v3 28/40] meson.build: move TCG plugin summary output, (continued)
- [PATCH v3 28/40] meson.build: move TCG plugin summary output, Alex Bennée, 2021/07/09
- [PATCH v3 27/40] plugins: fix-up handling of internal hostaddr for 32 bit, Alex Bennée, 2021/07/09
- [PATCH v3 26/40] tests/tcg: make test-mmap a little less aggressive, Alex Bennée, 2021/07/09
- [PATCH v3 22/40] tests/docker: expand ubuntu2004 package list, Alex Bennée, 2021/07/09
- [PATCH v3 20/40] tests/docker: expand fedora package list, Alex Bennée, 2021/07/09
- [PATCH v3 30/40] configure: add an explicit static and plugins check, Alex Bennée, 2021/07/09
- [PATCH v3 29/40] configure: don't allow plugins to be enabled for a non-TCG build, Alex Bennée, 2021/07/09
- [PATCH v3 31/40] configure: stop user enabling plugins on Windows for now, Alex Bennée, 2021/07/09
- [PATCH v3 23/40] tests/docker: expand opensuse-leap package list, Alex Bennée, 2021/07/09
- [PATCH v3 13/40] tests/docker: remove FEATURES env var from templates, Alex Bennée, 2021/07/09
- [PATCH v3 33/40] contrib/plugins: enable -Wall for building plugins,
Alex Bennée <=
- [PATCH v3 39/40] docs/devel: Added cache plugin to the plugins docs, Alex Bennée, 2021/07/09
- [PATCH v3 37/40] plugins/cache: Enable cache parameterization, Alex Bennée, 2021/07/09
- [PATCH v3 25/40] tests/vm: update openbsd to release 6.9, Alex Bennée, 2021/07/09
- [PATCH v3 34/40] contrib/plugins: add execlog to log instruction execution and memory access, Alex Bennée, 2021/07/09
- [PATCH v3 35/40] docs/devel: tcg-plugins: add execlog plugin description, Alex Bennée, 2021/07/09
- [PATCH v3 36/40] plugins: Added a new cache modelling plugin, Alex Bennée, 2021/07/09