[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] target/hppa: Use tcg_constant_*
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/2] target/hppa: Use tcg_constant_* |
|
Date: |
Fri, 9 Jul 2021 18:15:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/9/21 4:24 PM, Richard Henderson wrote:
> On 7/9/21 12:08 AM, Philippe Mathieu-Daudé wrote:
>> What about this one?
>>
>> @@ -3385,7 +3385,7 @@ static bool do_depw_sar(DisasContext *ct
>> /* Convert big-endian bit numbering in SAR to left-shift. */
>> tcg_gen_xori_reg(shift, cpu_sar, TARGET_REGISTER_BITS - 1);
>>
>> - mask = tcg_const_reg(msb + (msb - 1));
>> + mask = tcg_constant_reg(msb + (msb - 1));
>> tcg_gen_and_reg(tmp, val, mask);
>> if (rs) {
>> tcg_gen_shl_reg(mask, mask, shift);
>
> Also used as destination, so it's an initialized temp not a constant.
Obviously... Sorry :)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>