[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/41] target/alpha: Remove use_exit_tb
From: |
Richard Henderson |
Subject: |
[PATCH 07/41] target/alpha: Remove use_exit_tb |
Date: |
Sat, 10 Jul 2021 08:31:09 -0700 |
We have not needed to end a TB for I/O since ba3e7926691
("icount: clean up cpu_can_io at the entry to the block").
We do not need to use exit_tb for singlestep, which only
means generate one insn per TB.
Which leaves only singlestep_enabled, which means raise a
debug trap after every TB, which does not use exit_tb,
which would leave the function mis-named.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/alpha/translate.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index a607c898f4..cb2cb2de6b 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -449,19 +449,8 @@ static bool in_superpage(DisasContext *ctx, int64_t addr)
#endif
}
-static bool use_exit_tb(DisasContext *ctx)
-{
- return ((tb_cflags(ctx->base.tb) & CF_LAST_IO)
- || ctx->base.singlestep_enabled
- || singlestep);
-}
-
static bool use_goto_tb(DisasContext *ctx, uint64_t dest)
{
- /* Suppress goto_tb in the case of single-steping and IO. */
- if (unlikely(use_exit_tb(ctx))) {
- return false;
- }
#ifndef CONFIG_USER_ONLY
/* If the destination is in the superpage, the page perms can't change. */
if (in_superpage(ctx, dest)) {
@@ -1270,7 +1259,7 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, int
palcode)
need the page permissions check. We'll see the existence of
the page when we create the TB, and we'll flush all TBs if
we change the PAL base register. */
- if (!use_exit_tb(ctx)) {
+ if (!ctx->base.singlestep_enabled) {
tcg_gen_goto_tb(0);
tcg_gen_movi_i64(cpu_pc, entry);
tcg_gen_exit_tb(ctx->base.tb, 0);
@@ -3094,7 +3083,7 @@ static void alpha_tr_tb_stop(DisasContextBase *dcbase,
CPUState *cpu)
tcg_gen_movi_i64(cpu_pc, ctx->base.pc_next);
/* FALLTHRU */
case DISAS_PC_UPDATED:
- if (!use_exit_tb(ctx)) {
+ if (!ctx->base.singlestep_enabled) {
tcg_gen_lookup_and_goto_ptr();
break;
}
--
2.25.1
- [PATCH 00/41] tcg patch queue, Richard Henderson, 2021/07/10
- [PATCH 03/41] accel/tcg: Hoist tcg_tb_insert() up above tb_link_page(), Richard Henderson, 2021/07/10
- [PATCH 02/41] tcg: Avoid including 'trace-tcg.h' in target translate.c, Richard Henderson, 2021/07/10
- [PATCH 04/41] tcg: Bake tb_destroy() into tcg_region_tree, Richard Henderson, 2021/07/10
- [PATCH 01/41] tcg: Add separator in INDEX_op_call dump, Richard Henderson, 2021/07/10
- [PATCH 06/41] accel/tcg: Introduce translator_use_goto_tb, Richard Henderson, 2021/07/10
- [PATCH 05/41] tcg: Move tb_phys_invalidate_count to tb_ctx, Richard Henderson, 2021/07/10
- [PATCH 07/41] target/alpha: Remove use_exit_tb,
Richard Henderson <=
- [PATCH 08/41] target/alpha: Remove in_superpage, Richard Henderson, 2021/07/10
- [PATCH 09/41] target/alpha: Use translator_use_goto_tb, Richard Henderson, 2021/07/10
- [PATCH 10/41] target/arm: Use DISAS_TOO_MANY for ISB and SB, Richard Henderson, 2021/07/10
- [PATCH 11/41] target/arm: Use translator_use_goto_tb for aarch64, Richard Henderson, 2021/07/10
- [PATCH 12/41] target/arm: Use translator_use_goto_tb for aarch32, Richard Henderson, 2021/07/10
- [PATCH 14/41] target/avr: Mark some helpers noreturn, Richard Henderson, 2021/07/10
- [PATCH 18/41] target/m68k: Use translator_use_goto_tb, Richard Henderson, 2021/07/10
- [PATCH 13/41] target/avr: Use translator_use_goto_tb, Richard Henderson, 2021/07/10
- [PATCH 17/41] target/i386: Use translator_use_goto_tb, Richard Henderson, 2021/07/10
- [PATCH 15/41] target/cris: Use translator_use_goto_tb, Richard Henderson, 2021/07/10