[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 4/4] hw/sd: sdhci: Enable 64-bit system bus capability in the
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 4/4] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller |
Date: |
Mon, 12 Jul 2021 12:20:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/11/21 11:10 PM, Philippe Mathieu-Daudé wrote:
> From: Joanne Koong <joannekoong@gmail.com>
>
> The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus
> capability
> was added in v2.
>
> In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul <<
> 28))
> where 28 represents the BUS64BIT SDHC_CAPAB field.
>
> Signed-off-by: Joanne Koong <joannekoong@gmail.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Message-Id: <20210623185921.24113-1-joannekoong@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/sd/sdhci-internal.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
> index e8c753d6d1e..a76fc704e5e 100644
> --- a/hw/sd/sdhci-internal.h
> +++ b/hw/sd/sdhci-internal.h
> @@ -316,16 +316,16 @@ extern const VMStateDescription sdhci_vmstate;
> * - 3.3v and 1.8v voltages
> * - SDMA/ADMA1/ADMA2
> * - high-speed
> + * - 64-bit system bus
> * max host controller R/W buffers size: 512B
> * max clock frequency for SDclock: 52 MHz
> * timeout clock frequency: 52 MHz
> *
> * does not support:
> * - 3.0v voltage
> - * - 64-bit system bus
> * - suspend/resume
> */
> -#define SDHC_CAPAB_REG_DEFAULT 0x057834b4
> +#define SDHC_CAPAB_REG_DEFAULT 0x157834b4
>
> #define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \
> DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \
>
Unfortunately this breaks the TYPE_IMX_USDHC model for which
I don't have the datasheet, so I don't know how to fix it.
I suppose it is simpler to remove the COMMON_PROPERTIES macro
to avoid such problems.
- [PULL 0/4] SD/MMC patches for 2021-07-11, Philippe Mathieu-Daudé, 2021/07/11
- [PULL 1/4] hw/sd/sdcard: When card is in wrong state, log which state it is, Philippe Mathieu-Daudé, 2021/07/11
- [PULL 2/4] hw/sd/sdcard: Extract address_in_range() helper, log invalid accesses, Philippe Mathieu-Daudé, 2021/07/11
- [PULL 3/4] hw/sd/sdcard: Check for valid address range in SEND_WRITE_PROT (CMD30), Philippe Mathieu-Daudé, 2021/07/11
- [PULL 4/4] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller, Philippe Mathieu-Daudé, 2021/07/11
- Re: [PULL 4/4] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller,
Philippe Mathieu-Daudé <=
- Re: [PULL 0/4] SD/MMC patches for 2021-07-11, Philippe Mathieu-Daudé, 2021/07/12