Re: [PULL v2 00/48] Misc patches for QEMU 6.1 soft freeze

[Daniel P . Berrangé]

On Mon, Jul 12, 2021 at 11:01:55AM +0100, Peter Maydell wrote:
> On Sat, 10 Jul 2021 at 20:01, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > The following changes since commit 05de778b5b8ab0b402996769117b88c7ea5c7c61:
> >
> >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging 
> > (2021-07-09 14:30:01 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/bonzini/qemu.git tags/for-upstream
> >
> > for you to fetch changes up to 411ad8dd80077e98ed465775b044caf1a9482f6c:
> >
> >   meson: Use input/output for entitlements target (2021-07-09 18:21:34 
> > +0200)
> >
> > v1->v2: fix docs build, add final patch for entitlements target
> >
> > ----------------------------------------------------------------
> > * More SVM fixes (Lara)
> > * Module annotation database (Gerd)
> > * Memory leak fixes (myself)
> > * Build fixes (myself)
> > * --with-devices-* support (Alex)
> >
> > ----------------------------------------------------------------
> 
> 
> Applied, thanks.
> 
> Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
> for any user-visible changes.

This series has broken the build for me:

/usr/bin/ld: libqemuutil.a(util_async.c.o): in function 
`aio_setup_linux_io_uring':
/home/berrange/src/virt/qemu/build/../util/async.c:421: undefined reference to 
`luring_init'
/usr/bin/ld: /home/berrange/src/virt/qemu/build/../util/async.c:426: undefined 
reference to `luring_attach_aio_context'
/usr/bin/ld: libqemuutil.a(util_async.c.o): in function `aio_ctx_finalize':
/home/berrange/src/virt/qemu/build/../util/async.c:334: undefined reference to 
`luring_detach_aio_context'
/usr/bin/ld: /home/berrange/src/virt/qemu/build/../util/async.c:335: undefined 
reference to `luring_cleanup'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

git bisect blames:

commit 63a7f853063133fd1aa34ab0744b009fa3d7e183 (refs/bisect/bad)
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu Jul 8 13:50:06 2021 +0200

    meson: fix missing preprocessor symbols
    
    While most libraries do not need a CONFIG_* symbol because the
    "when:" clauses are enough, some do.  Add them back or stop
    using them if possible.
    
    In the case of libpmem, the statement to add the CONFIG_* symbol
    was still in configure, but could not be triggered because it
    checked for "no" instead of "disabled" (and it would be wrong anyway
    since the test for the library has not been done yet).
    
    Reported-by: Li Zhijian <lizhijian@cn.fujitsu.com>
    Fixes: 587d59d6cc ("configure, meson: convert virgl detection to meson", 
2021-07-06)
    Fixes: 83ef16821a ("configure, meson: convert libdaxctl detection to 
meson", 2021-07-06)
    Fixes: e36e8c70f6 ("configure, meson: convert libpmem detection to meson", 
2021-07-06)
    Fixes: 53c22b68e3 ("configure, meson: convert liburing detection to meson", 
2021-07-06)
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>




IIUC, we didn't detect this in gitlab CI because liburing-devel is not
present in any of the dockerfiles currently in git master. This omission
is fixed in my series here which will be in Alex's next pull:

  https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06374.html

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|