[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDis

From: Cleber Rosa
Subject: Re: [PATCH v5 1/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class
Date: Mon, 12 Jul 2021 09:26:58 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/8/21 3:32 PM, Eric Auger wrote:
Hi Cleber,

On 7/8/21 7:34 PM, Cleber Rosa wrote:
On 7/8/21 4:56 AM, Eric Auger wrote:
I am not sufficiently expert on the test infra and python to be really
efficient fixing that. Can anyone help quickly to target the soft
freeze? Otherwise, today I will drop that patch and restore the code I
had in v4, just based on Cleber series. I think the refactoring can
happen later...

Hi Eric,

The following diff works for me:

diff --git a/tests/acceptance/avocado_qemu/__init__.py
index af93cd63ea..b3bed00062 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -310,6 +310,8 @@ class LinuxDistro:
              '31': {
+                'aarch64':
+                {'checksum':
@@ -323,10 +325,11 @@ def __init__(self, name, version, arch):
          self.version = version
          self.arch = arch
-            self._info =
+            info = self.KNOWN_DISTROS.get(name).get(version).get(arch)
          except AttributeError:
              # Unknown distro
-            self._info = {}
+            info = None
+        self._info = info or {}

      def checksum(self):

I've tested it with both existing and the newly introduced tests.
Thank you for the work! Do you plan to introduce it as a fixup or do I
need to respin?

Hi Eric,

Yes, I can add it as a fixup.


- Cleber.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]