[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

From: Cole Robinson
Subject: Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix
Date: Mon, 12 Jul 2021 17:30:27 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/12/21 11:59 AM, Richard Henderson wrote:
> The first two patches are not strictly required, but they
> were useful in tracking down the root problem here.
> I understand the logic behind the clang-12 warning, but I think
> it's a clear mistake that it should be enabled by default for a
> target where alignment is not enforced by default.
> I found over a dozen places where we would have to manually add
> QEMU_ALIGNED(8) to uint64_t declarations in order to suppress
> all of the instances.  IMO there's no point fighting this.

I tested your patches, they seem to get rid of the warnings. The errors

FWIW here's my reproduce starting from fedora 34 x86_64 host:

$ sudo mock --root fedora-35-i386 --install dnf --install dnf-utils
--install fedora-packager --install clang
$ sudo mock --root fedora-35-i386 --shell --enable-network
# dnf builddep -y qemu
# git clone https://github.com/qemu/qemu
# cd qemu
# CC=clang CXX=clang++ ./configure --disable-werror
# make V=1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]