[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] vl: Parse legacy default_machine_opts
From: |
Jason Andryuk |
Subject: |
[PATCH] vl: Parse legacy default_machine_opts |
Date: |
Mon, 12 Jul 2021 22:15:52 -0400 |
qemu can't start a xen vm after commit d8fb7d0969d5
"vl: switch -M parsing to keyval" with:
$ ./qemu-system-i386 -M xenfv
Unexpected error in object_property_find_err() at ../qom/object.c:1298:
qemu-system-i386: Property 'xenfv-3.1-machine.accel' not found
Aborted (core dumped)
The default_machine_opts handling doesn't process the legacy machine
options like "accel". Call qemu_apply_legacy_machine_options to provide
the legacy handling.
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
softmmu/vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 4df1496101..f4d8630fc6 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -2126,6 +2126,7 @@ static void qemu_create_machine(QDict *qdict)
QDict *default_opts =
keyval_parse(machine_class->default_machine_opts, NULL, NULL,
&error_abort);
+ qemu_apply_legacy_machine_options(default_opts);
object_set_properties_from_keyval(OBJECT(current_machine),
default_opts,
false, &error_abort);
qobject_unref(default_opts);
--
2.30.2
- [PULL 24/40] meson: store dependency('threads') in a variable, (continued)
- [PULL 24/40] meson: store dependency('threads') in a variable, Paolo Bonzini, 2021/07/06
- [PULL 28/40] configure: convert compiler tests to meson, part 2, Paolo Bonzini, 2021/07/06
- [PULL 29/40] configure: convert compiler tests to meson, part 3, Paolo Bonzini, 2021/07/06
- [PULL 31/40] configure: convert compiler tests to meson, part 5, Paolo Bonzini, 2021/07/06
- [PULL 30/40] configure: convert compiler tests to meson, part 4, Paolo Bonzini, 2021/07/06
- [PULL 33/40] qom: export more functions for use with non-UserCreatable objects, Paolo Bonzini, 2021/07/06
- [PULL 40/40] config-host.mak: remove unused compiler-related lines, Paolo Bonzini, 2021/07/06
- [PULL 35/40] keyval: introduce keyval_parse_into, Paolo Bonzini, 2021/07/06
- [PULL 36/40] vl: switch -M parsing to keyval, Paolo Bonzini, 2021/07/06
- Re: [PULL 36/40] vl: switch -M parsing to keyval, Volker RĂ¼melin, 2021/07/12
- Re: [PULL 36/40] vl: switch -M parsing to keyval, Alex Williamson, 2021/07/13
Re: [PULL 36/40] vl: switch -M parsing to keyval, Peter Krempa, 2021/07/22