[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 1/2] hw/nvme: add mi device
From: |
Christoph Hellwig |
Subject: |
Re: [RFC PATCH 1/2] hw/nvme: add mi device |
Date: |
Tue, 13 Jul 2021 06:30:28 +0100 |
On Mon, Jul 12, 2021 at 12:03:27PM +0100, Stefan Hajnoczi wrote:
> Why did you decide to implement -device nvme-mi as a device on
> TYPE_NVME_BUS? If the NVMe spec somehow requires this then I'm surprised
> that there's no NVMe bus interface (callbacks). It seems like this could
> just as easily be a property of an NVMe controller -device
> nvme,mi=on|off or -device nvme-subsys,mi=on|off? I'm probably just not
> familiar enough with MI and NVMe architecture...
I'm too far away from qemu these days to understand what TYPE_NVME_BUS
is. Bt NVMe-MI has tree possible transports:
1) out of band through smbus. This seems something that could be
trivially modelled in qemu
2) out of band over MCTP / PCIe VDM.
3) in band using NVMe admin commands that pass through MI commands