[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/1] target/arm: Fix offsets for TTBCR (#187)

From: Peter Maydell
Subject: Re: [PATCH 0/1] target/arm: Fix offsets for TTBCR (#187)
Date: Tue, 13 Jul 2021 15:48:14 +0100

On Sat, 10 Jul 2021 at 00:07, Richard Henderson
<richard.henderson@linaro.org> wrote:
> This one patch fixes boot_linux_console test_arm_virt.
> It does not fix all of the failures.  The next one on the
> list is test_arm_emcraft_sf2, where the cpu boots fine but
> the net device doesn't work correctly.

Applied to target-arm.next, thanks.

I'm not sure the TCR struct's precalculation of mask and base_mask
is still earning its keep as an optimization. We only use them in
get_level1_table_address() which is old-style v5/v6 page tables only,
and all it's saving us is a bitfield extract and some shifts, which
is peanuts compared to everything else we do in a page table walk.
Perhaps (not for 6.1) we could drop it entirely.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]