[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure: Drop obsolete check for the alloc_size attribute

From: Paolo Bonzini
Subject: Re: [PATCH] configure: Drop obsolete check for the alloc_size attribute
Date: Wed, 14 Jul 2021 16:56:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 14/07/21 09:28, Thomas Huth wrote:
We recently bumped our requirement for Clang to at least version 6.0.
And according to:


Clang v6.0 supports the alloc_size attribute. Thus we can drop this
check in the configure script now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
  configure | 12 ------------
  1 file changed, 12 deletions(-)

diff --git a/configure b/configure
index a0a32c427c..eee1356814 100755
--- a/configure
+++ b/configure
@@ -3184,18 +3184,6 @@ if ! compile_prog "$glib_cflags" "$glib_libs" ; then
               "build target"
-# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
-cat > $TMPC << EOF
-#include <glib.h>
-int main(void) { return 0; }
-if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then
-    if cc_has_warning_flag "-Wno-unknown-attributes"; then
-        glib_cflags="-Wno-unknown-attributes $glib_cflags"
-        CONFIGURE_CFLAGS="-Wno-unknown-attributes $CONFIGURE_CFLAGS"
-    fi
  # Silence clang warnings triggered by glib < 2.57.2
  cat > $TMPC << EOF
  #include <glib.h>

Queued, thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]