Re: [PATCH v3 0/3] support dirtyrate measurement with dirty bitmap

[Peter Xu]

On Thu, Jul 15, 2021 at 11:51:30PM +0800, huangy81@chinatelecom.cn wrote:
> Hyman Huang(黄勇) (3):
>   KVM: introduce kvm_get_manual_dirty_log_protect
>   memory: introduce DirtyRateDirtyPages and util function
>   migration/dirtyrate: implement dirty-bitmap dirtyrate calculation
> 
>  accel/kvm/kvm-all.c     |   6 +++
>  hmp-commands.hx         |   9 ++--
>  include/exec/ram_addr.h |  19 ++++++++
>  include/sysemu/kvm.h    |   1 +
>  migration/dirtyrate.c   | 118 
> ++++++++++++++++++++++++++++++++++++++++++++----
>  migration/trace-events  |   1 +
>  qapi/migration.json     |   6 ++-
>  7 files changed, 145 insertions(+), 15 deletions(-)

Yeah this diff looks much nicer. :)

I still have a few last comments here and there, please see each patch.  Thanks.

-- 
Peter Xu