[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/9] plugins/hotpages: introduce sortby arg and parsed bool args
From: |
Mahmoud Mandour |
Subject: |
[PATCH 3/9] plugins/hotpages: introduce sortby arg and parsed bool args correctly |
Date: |
Fri, 16 Jul 2021 10:03:39 +0200 |
Since plugin arguments now expect boolean arguments, a plugin argument
name "sortby" now expects a value of "read", "write", or "address".
"io" arg is now expected to be passed as a full-form boolean parameter,
i.e. "io=on|true|yes|off|false|no"
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
---
contrib/plugins/hotpages.c | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c
index bf53267532..0d12910af6 100644
--- a/contrib/plugins/hotpages.c
+++ b/contrib/plugins/hotpages.c
@@ -169,16 +169,26 @@ int qemu_plugin_install(qemu_plugin_id_t id, const
qemu_info_t *info,
for (i = 0; i < argc; i++) {
char *opt = argv[i];
- if (g_strcmp0(opt, "reads") == 0) {
- sort_by = SORT_R;
- } else if (g_strcmp0(opt, "writes") == 0) {
- sort_by = SORT_W;
- } else if (g_strcmp0(opt, "address") == 0) {
- sort_by = SORT_A;
- } else if (g_strcmp0(opt, "io") == 0) {
- track_io = true;
- } else if (g_str_has_prefix(opt, "pagesize=")) {
- page_size = g_ascii_strtoull(opt + 9, NULL, 10);
+ g_autofree char **tokens = g_strsplit(opt, "=", -1);
+
+ if (g_strcmp0(tokens[0], "sortby") == 0) {
+ if (g_strcmp0(tokens[1], "reads") == 0) {
+ sort_by = SORT_R;
+ } else if (g_strcmp0(tokens[1], "writes") == 0) {
+ sort_by = SORT_W;
+ } else if (g_strcmp0(tokens[1], "address") == 0) {
+ sort_by = SORT_A;
+ } else {
+ fprintf(stderr, "invalid value to sortby: %s\n", tokens[1]);
+ return -1;
+ }
+ } else if (g_strcmp0(tokens[0], "io") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &track_io)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", opt);
+ return -1;
+ }
+ } else if (g_strcmp0(tokens[0], "pagesize") == 0) {
+ page_size = g_ascii_strtoull(tokens[1], NULL, 10);
} else {
fprintf(stderr, "option parsing failed: %s\n", opt);
return -1;
--
2.25.1
- [PATCH 0/9] new plugin argument passing scheme, Mahmoud Mandour, 2021/07/16
- [PATCH 1/9] plugins: allow plugin arguments to be passed directly, Mahmoud Mandour, 2021/07/16
- [PATCH 2/9] plugins/api: added a boolean parsing plugin api, Mahmoud Mandour, 2021/07/16
- [PATCH 3/9] plugins/hotpages: introduce sortby arg and parsed bool args correctly,
Mahmoud Mandour <=
- [PATCH 4/9] plugins/hotblocks: Added correct boolean argument parsing, Mahmoud Mandour, 2021/07/16
- [PATCH 5/9] plugins/lockstep: make socket path not positional & parse bool arg, Mahmoud Mandour, 2021/07/16
- [PATCH 6/9] plugins/hwprofile: adapt to the new plugin arguments scheme, Mahmoud Mandour, 2021/07/16
- [PATCH 8/9] docs/tcg-plugins: new passing parameters scheme for cache docs, Mahmoud Mandour, 2021/07/16
- [PATCH 7/9] plugins/howvec: Adapting to the new argument passing scheme., Mahmoud Mandour, 2021/07/16
- [PATCH 9/9] docs/deprecated: deprecate passing plugin args through `arg=`, Mahmoud Mandour, 2021/07/16
- Re: [PATCH 0/9] new plugin argument passing scheme, Mahmoud Mandour, 2021/07/16