[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

From: Alex Bennée
Subject: Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds
Date: Fri, 16 Jul 2021 14:16:01 +0100
User-agent: mu4e 1.5.13; emacs 28.0.50

Christian Borntraeger <borntraeger@de.ibm.com> writes:

> On 16.07.21 08:54, Christian Borntraeger wrote:
>> On 12.07.21 14:26, Alex Bennée wrote:
>>> Aside from a minor bloat to file size the ability to have TCG plugins
>>> has no real impact on performance unless a plugin is actively loaded.
>>> Even then the libempty.so plugin shows only a minor degradation in
>>> performance caused by the extra book keeping the TCG has to do to keep
>>> track of instructions. As it's a useful feature lets just enable it by
>>> default and reduce our testing matrix a little.
>>> We need to move our linker testing earlier so we can be sure we can
>>> enable the loader module required. As we have ruled out static &
>>> plugins in an earlier patch we can also reduce the indent a little.
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> Message-Id: <20210709143005.1554-33-alex.bennee@linaro.org>
>> I cant reproduce it manually but in our build regression this fails
>> with
> I can now reproduce when adding
>  --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now"
> to the configure script (on "20.04.2 LTS)

Whats your full configure line? And this is on the s390x-cloud machine?

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]