Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

[Richard Henderson]

On 7/16/21 8:31 AM, Christian Borntraeger wrote:
> On 16.07.21 16:58, Christian Borntraeger wrote:
> > On 16.07.21 16:51, Richard Henderson wrote:
> > > On 7/16/21 4:28 AM, Christian Borntraeger wrote:
> > > >   --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now"
> >
> > Full configure line is
> >
> > ../configure     --prefix=/usr     --libdir=/usr/lib64     --sysconfdir=/etc     
> > --interp-prefix=/usr/qemu-%M     --localstatedir=/var     --libexecdir=/usr/libexec     
> > --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now"     --extra-cflags="-O2 -g 
> > -fPIE -DPIE"     --enable-werror     --disable-strip     --disable-rbd     
> > --disable-fdt        --disable-xen     --enable-kvm     --enable-trace-backend=log      
> > --iasl=false     --target-list=s390x-softmmu,i386-softmmu,x86_64-softmmu,s390x-linux-user
> >
> >
> > > FWIW, -pie should not be buried in --extra-ldflags, but as --enable-pie on the normal 
> > > configure line.
> >
> > I picked that from the configure script of an older fedora qemu src rpm some years ago 
> > and I use that to do build checks.
>
> using enable-pie instead of burying it in the ldflags seems to fix things.
> Question is do we still care about this regression?

I don't think so.  Your incorrect ldflags (appropriate for the main executable, perhaps) 
was leaking into the shared library plugins, where -shared and -pie conflict.


r~