[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/13] plugins/howvec: Adapting to the new argument passing schem
From: |
Mahmoud Mandour |
Subject: |
[PATCH 07/13] plugins/howvec: Adapting to the new argument passing scheme. |
Date: |
Sat, 17 Jul 2021 12:09:14 +0200 |
Correctly parsing plugin argument since they now must be provided as
full-form boolean parameters, e.g.:
-plugin ./contrib/plugins/libhowvec.so,verbose=on,inline=on
Also, introduced the argument "count" that accepts one opt to count
individually at a time.
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
---
contrib/plugins/howvec.c | 27 +++++++++++++++++++--------
docs/devel/tcg-plugins.rst | 10 +++++-----
2 files changed, 24 insertions(+), 13 deletions(-)
diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c
index 600f7facc1..4a5ec3d936 100644
--- a/contrib/plugins/howvec.c
+++ b/contrib/plugins/howvec.c
@@ -333,23 +333,34 @@ QEMU_PLUGIN_EXPORT int
qemu_plugin_install(qemu_plugin_id_t id,
for (i = 0; i < argc; i++) {
char *p = argv[i];
- if (strcmp(p, "inline") == 0) {
- do_inline = true;
- } else if (strcmp(p, "verbose") == 0) {
- verbose = true;
- } else {
+ g_autofree char **tokens = g_strsplit(p, "=", -1);
+ if (g_strcmp0(tokens[0], "inline") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_inline)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", p);
+ return -1;
+ }
+ } else if (g_strcmp0(tokens[0], "verbose") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &verbose)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", p);
+ return -1;
+ }
+ } else if (g_strcmp0(tokens[0], "count") == 0) {
+ char *value = tokens[1];
int j;
CountType type = COUNT_INDIVIDUAL;
- if (*p == '!') {
+ if (*value == '!') {
type = COUNT_NONE;
- p++;
+ value++;
}
for (j = 0; j < class_table_sz; j++) {
- if (strcmp(p, class_table[j].opt) == 0) {
+ if (strcmp(value, class_table[j].opt) == 0) {
class_table[j].what = type;
break;
}
}
+ } else {
+ fprintf(stderr, "option parsing failed: %s\n", p);
+ return -1;
}
}
diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index 753f56ac42..4ab9dc4bb1 100644
--- a/docs/devel/tcg-plugins.rst
+++ b/docs/devel/tcg-plugins.rst
@@ -79,7 +79,7 @@ Once built a program can be run with multiple plugins loaded
each with
their own arguments::
$QEMU $OTHER_QEMU_ARGS \
- -plugin tests/plugin/libhowvec.so,arg=inline,arg=hint \
+ -plugin tests/plugin/libhowvec.so,inline=on,count=hint \
-plugin tests/plugin/libhotblocks.so
Arguments are plugin specific and can be used to modify their
@@ -196,13 +196,13 @@ Similar to hotblocks but this time tracks memory
accesses::
This is an instruction classifier so can be used to count different
types of instructions. It has a number of options to refine which get
-counted. You can give an argument for a class of instructions to break
-it down fully, so for example to see all the system registers
-accesses::
+counted. You can give a value to the `count` argument for a class of
+instructions to break it down fully, so for example to see all the system
+registers accesses::
./aarch64-softmmu/qemu-system-aarch64 $(QEMU_ARGS) \
-append "root=/dev/sda2 systemd.unit=benchmark.service" \
- -smp 4 -plugin ./contrib/plugins/libhowvec.so,arg=sreg -d plugin
+ -smp 4 -plugin ./contrib/plugins/libhowvec.so,count=sreg -d plugin
which will lead to a sorted list after the class breakdown::
--
2.25.1
- [PATCH 00/13] new plugin argument passing scheme, Mahmoud Mandour, 2021/07/17
- [PATCH 01/13] plugins: allow plugin arguments to be passed directly, Mahmoud Mandour, 2021/07/17
- [PATCH 06/13] plugins/hwprofile: adapt to the new plugin arguments scheme, Mahmoud Mandour, 2021/07/17
- [PATCH 02/13] plugins/api: added a boolean parsing plugin api, Mahmoud Mandour, 2021/07/17
- [PATCH 07/13] plugins/howvec: Adapting to the new argument passing scheme.,
Mahmoud Mandour <=
- [PATCH 03/13] plugins/hotpages: introduce sortby arg and parsed bool args correctly, Mahmoud Mandour, 2021/07/17
- [PATCH 05/13] plugins/lockstep: make socket path not positional & parse bool arg, Mahmoud Mandour, 2021/07/17
- [PATCH 08/13] docs/tcg-plugins: new passing parameters scheme for cache docs, Mahmoud Mandour, 2021/07/17
- [PATCH 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool, Mahmoud Mandour, 2021/07/17
- [PATCH 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme, Mahmoud Mandour, 2021/07/17