[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 06/13] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_at
From: |
Richard Henderson |
Subject: |
[PATCH v3 06/13] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic |
Date: |
Sat, 17 Jul 2021 15:18:44 -0700 |
Request that the one TB returns immediately, so that
we release the exclusive lock as soon as possible.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/cpu-exec.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 2206c463f5..5bb099174f 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -330,8 +330,7 @@ void cpu_exec_step_atomic(CPUState *cpu)
CPUArchState *env = (CPUArchState *)cpu->env_ptr;
TranslationBlock *tb;
target_ulong cs_base, pc;
- uint32_t flags;
- uint32_t cflags = (curr_cflags(cpu) & ~CF_PARALLEL) | 1;
+ uint32_t flags, cflags;
int tb_exit;
if (sigsetjmp(cpu->jmp_env, 0) == 0) {
@@ -341,8 +340,14 @@ void cpu_exec_step_atomic(CPUState *cpu)
cpu->running = true;
cpu_get_tb_cpu_state(env, &pc, &cs_base, &flags);
- tb = tb_lookup(cpu, pc, cs_base, flags, cflags);
+ cflags = curr_cflags(cpu);
+ /* Execute in a serial context. */
+ cflags &= ~CF_PARALLEL;
+ /* After 1 insn, return and release the exclusive lock. */
+ cflags |= CF_NO_GOTO_TB | CF_NO_GOTO_PTR | 1;
+
+ tb = tb_lookup(cpu, pc, cs_base, flags, cflags);
if (tb == NULL) {
mmap_lock();
tb = tb_gen_code(cpu, pc, cs_base, flags, cflags);
--
2.25.1
- Re: [PATCH v3 01/13] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS, (continued)
- [PATCH v3 04/13] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain, Richard Henderson, 2021/07/17
- [PATCH v3 05/13] accel/tcg: Handle -singlestep in curr_cflags, Richard Henderson, 2021/07/17
- [PATCH v3 09/13] target/mips: Reduce mips_tr_breakpoint_check pc advance to 2, Richard Henderson, 2021/07/17
- [PATCH v3 07/13] accel/tcg: Move cflags lookup into tb_find, Richard Henderson, 2021/07/17
- [PATCH v3 02/13] accel/tcg: Move curr_cflags into cpu-exec.c, Richard Henderson, 2021/07/17
- [PATCH v3 06/13] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic,
Richard Henderson <=
- [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check, Richard Henderson, 2021/07/17
- [PATCH v3 12/13] accel/tcg: Hoist tb_cflags to a local in translator_loop, Richard Henderson, 2021/07/17
- [PATCH v3 03/13] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR, Richard Henderson, 2021/07/17
- [PATCH v3 13/13] accel/tcg: Encode breakpoint info into tb->cflags, Richard Henderson, 2021/07/17
- [PATCH v3 11/13] accel/tcg: Adjust interface of TranslatorOps.breakpoint_check, Richard Henderson, 2021/07/17
- [PATCH v3 10/13] target/riscv: Reduce riscv_tr_breakpoint_check pc advance to 2, Richard Henderson, 2021/07/17