[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 44/48] meson: Introduce target-specific Kconfig
From: |
Peter Maydell |
Subject: |
Re: [PULL 44/48] meson: Introduce target-specific Kconfig |
Date: |
Sat, 17 Jul 2021 23:59:09 +0100 |
On Thu, 8 Jul 2021 at 16:49, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Add a target-specific Kconfig. We need the definitions in Kconfig so
> the minikconf tool can verify they exits. However CONFIG_FOO is only
> enabled for target foo via the meson.build rules.
>
> Two architecture have a particularity, ARM and MIPS. As their
> translators have been split you can potentially build a plain 32 bit
> build along with a 64-bit version including the 32-bit subset.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Message-Id: <20210131111316.232778-6-f4bug@amsat.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <20210707131744.26027-2-alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Hi; this change (commit f4063f9c319e392 in master) seems to have
resulted in qemu-system-tricore no longer building the
'tricore_testboard'. Before this commit:
$ ./build/tricore/qemu-system-tricore -M help
Supported machines are:
KIT_AURIX_TC277_TRB Infineon AURIX TriBoard TC277 (D-Step)
none empty machine
tricore_testboard a minimal TriCore board
After this commit, 'tricore_testboard' no longer appears in the list.
The hw/tricore/meson.build uses "when: 'CONFIG_TRICORE'" to
compile the source files for the board, so presumably that
CONFIG switch is no longer being defined ?
This in turn breaks 'make check-tcg' for builds which build
tricore-softmmu, because some of the tests there want to run
code on the tricore_testboard:
[...]
RUN tests for tricore
TEST test_abs.tst on tricore
qemu-system-tricore: unsupported machine type
Use -machine help to list supported machines
../Makefile.target:168: recipe for target 'run-test_abs.tst' failed
(I guess we're not running "check-tcg" in gitlab CI. I do run
it locally, but only on a linux-user-only build tree, which is
why I didn't see this earlier.)
thanks
-- PMM
- [PULL 39/48] target/i386: Added MSRPM and IOPM size check, (continued)
- [PULL 39/48] target/i386: Added MSRPM and IOPM size check, Paolo Bonzini, 2021/07/08
- [PULL 40/48] target/i386: Added DR6 and DR7 consistency checks, Paolo Bonzini, 2021/07/08
- [PULL 36/48] monitor/usb: register 'info usbhost' dynamically, Paolo Bonzini, 2021/07/08
- [PULL 38/48] monitor/tcg: move tcg hmp commands to accel/tcg, register them dynamically, Paolo Bonzini, 2021/07/08
- [PULL 45/48] hw/arm: add dependency on OR_IRQ for XLNX_VERSAL, Paolo Bonzini, 2021/07/08
- [PULL 48/48] configure: allow the selection of alternate config in the build, Paolo Bonzini, 2021/07/08
- [PULL 31/48] accel: build qtest modular, Paolo Bonzini, 2021/07/08
- [PULL 41/48] target/i386: fix exceptions for MOV to DR, Paolo Bonzini, 2021/07/08
- [PULL 43/48] meson: switch function tests from compilation to linking, Paolo Bonzini, 2021/07/08
- [PULL 44/48] meson: Introduce target-specific Kconfig, Paolo Bonzini, 2021/07/08
- Re: [PULL 44/48] meson: Introduce target-specific Kconfig,
Peter Maydell <=
- [PULL 47/48] configs: rename default-configs to configs and reorganise, Paolo Bonzini, 2021/07/08
- [PULL 42/48] vl: fix leak of qdict_crumple return value, Paolo Bonzini, 2021/07/08
- [PULL 46/48] hw/arm: move CONFIG_V7M out of default-devices, Paolo Bonzini, 2021/07/08
- Re: [PULL 00/48] Misc patches for QEMU 6.1 soft freeze, Peter Maydell, 2021/07/09