qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-6.2 08/10] linux-user: Don't include gdbstub.h in qemu.h


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH for-6.2 08/10] linux-user: Don't include gdbstub.h in qemu.h
Date: Sun, 18 Jul 2021 09:50:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/18/21 1:21 AM, Peter Maydell wrote:
> Currently the linux-user qemu.h pulls in gdbstub.h. There's no real reason
> why it should do this; include it directly from the C files which require
> it, and drop the include line in qemu.h.
> 
> (Note that several of the C files previously relying on this indirect
> include were going out of their way to only include gdbstub.h conditionally
> on not CONFIG_USER_ONLY!)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  linux-user/qemu.h             | 1 -
>  gdbstub.c                     | 2 +-
>  linux-user/exit.c             | 1 +
>  linux-user/main.c             | 1 +
>  linux-user/signal.c           | 2 ++
>  semihosting/arm-compat-semi.c | 2 +-
>  target/m68k/m68k-semi.c       | 2 +-
>  target/nios2/nios2-semi.c     | 2 +-
>  8 files changed, 8 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]