qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/pci: remove all references to find_i440fx function


From: Ani Sinha
Subject: Re: [PATCH] hw/pci: remove all references to find_i440fx function
Date: Sun, 18 Jul 2021 22:14:33 +0530 (IST)
User-agent: Alpine 2.21 (DEB 202 2017-01-01)


On Sun, 18 Jul 2021, Philippe Mathieu-Daudé wrote:

> On 7/18/21 3:16 PM, Ani Sinha wrote:
> > commit c0e427d6eb5fefc538 ("hw/acpi/ich9: Enable ACPI PCI hot-plug") 
> > removed all
> > uses of find_i440fx() function. This has been replaced by the more generic 
> > call
> > acpi_get_i386_pci_host() which maybe able to find the root bus both for 
> > i440fx
> > machine type as well as for the q35 machine type. There seems to be no more 
> > any
> > need to maintain a i440fx specific version of the api call. Remove it.
>
> Yay!

Thanks to Julia for making it happen. I was wondering when I shall see
these patches ...

>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> > Tested by building from a clean tree successfully.
> >
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> >  hw/pci-host/i440fx.c         | 8 --------
> >  include/hw/pci-host/i440fx.h | 1 -
> >  stubs/meson.build            | 1 -
> >  stubs/pci-host-piix.c        | 7 -------
> >  4 files changed, 17 deletions(-)
> >  delete mode 100644 stubs/pci-host-piix.c
>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]