[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal |
Date: |
Tue, 20 Jul 2021 13:55:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/20/21 3:17 AM, Richard Henderson wrote:
> We are certain of a page crossing here, entering the
> PALcode image, so the call to use_goto_tb that should
> have been here will never succeed.
>
> We are shortly going to add an assert to tcg_gen_goto_tb
> that would trigger for this case.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/alpha/translate.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH for-6.1 v5 00/15] tcg: breakpoint reorg, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 01/15] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 02/15] accel/tcg: Move curr_cflags into cpu-exec.c, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal, Richard Henderson, 2021/07/19
- Re: [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal,
Philippe Mathieu-Daudé <=
- [PATCH for-6.1 v5 04/15] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 05/15] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 06/15] accel/tcg: Handle -singlestep in curr_cflags, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 07/15] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 11/15] accel/tcg: Merge tb_find into its only caller, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 12/15] accel/tcg: Move breakpoint recognition outside translation, Richard Henderson, 2021/07/19
- [PATCH for-6.1 v5 09/15] target/arm: Implement debug_check_breakpoint, Richard Henderson, 2021/07/19