[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-6.1] gitlab-ci: Extract OpenSBI job rules to reusable sec
Re: [PATCH-for-6.1] gitlab-ci: Extract OpenSBI job rules to reusable section
Tue, 20 Jul 2021 15:02:41 -0300
On Tue, Jul 20, 2021 at 1:48 PM Philippe Mathieu-Daudé
> All jobs depending on 'docker-opensbi' job must use at most all
> the rules that triggers it. The simplest way to ensure that
> is to always use the same rules. Extract all the rules to a
> reusable section, and include this section (with the 'extends'
> keyword) in both 'docker-opensbi' and 'build-opensbi' jobs.
> The problem was introduced in commit c6fc0fc1a71 ("gitlab-ci.yml:
> Add jobs to build OpenSBI firmware binaries"), but was revealed in
> commit 91e9c47e50a ("docker: OpenSBI build job depends on OpenSBI
> This fix is similar to the one used with the EDK2 firmware job in
> commit ac0595cf6b3 ("gitlab-ci: Extract EDK2 job rules to reusable
> Reported-by: Daniel P. Berrangé <email@example.com>
> Signed-off-by: Philippe Mathieu-Daudé <firstname.lastname@example.org>
> Latent bug on CI, safe for 6.1.
> .gitlab-ci.d/opensbi.yml | 28 +++++++++++++++++-----------
> 1 file changed, 17 insertions(+), 11 deletions(-)
Reviewed-by: Willian Rampazzo <email@example.com>